[MediaWiki-commits] [Gerrit] Explicitly define module position - change (mediawiki...UniversalLanguageSelector)

2015-05-06 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Explicitly define module position
..


Explicitly define module position

Style modules currently added through addModuleStyles default
to being in the head ("top" position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to "bottom",
existing module positions have to be defined explicitly.

Bug: T97410
Change-Id: I209f93a49ddd0aa143348c0238849a121856dce1
---
M Resources.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Resources.php b/Resources.php
index 4e0a8cf..0d05f64 100644
--- a/Resources.php
+++ b/Resources.php
@@ -271,6 +271,7 @@
 ) + $resourcePaths;
 
 $wgResourceModules['jquery.uls.grid'] = array(
+   'position' => 'top',
'styles' => 'lib/jquery.uls/css/jquery.uls.grid.css',
 ) + $resourcePaths;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/208977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I209f93a49ddd0aa143348c0238849a121856dce1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Gilles 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Explicitly define module position - change (mediawiki...UniversalLanguageSelector)

2015-05-05 Thread Gilles (Code Review) 
Gilles has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/208977

Change subject: Explicitly define module position
..

Explicitly define module position

Style modules currently added through addModuleStyles default
to being in the head ("top" position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to "bottom",
existing module positions have to be defined explicitly.

Bug: T97410
Change-Id: I209f93a49ddd0aa143348c0238849a121856dce1
---
M Resources.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/77/208977/1

diff --git a/Resources.php b/Resources.php
index 4e0a8cf..0d05f64 100644
--- a/Resources.php
+++ b/Resources.php
@@ -271,6 +271,7 @@
 ) + $resourcePaths;
 
 $wgResourceModules['jquery.uls.grid'] = array(
+   'position' => 'top',
'styles' => 'lib/jquery.uls/css/jquery.uls.grid.css',
 ) + $resourcePaths;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/208977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I209f93a49ddd0aa143348c0238849a121856dce1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Gilles 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits