[MediaWiki-commits] [Gerrit] Fix: Profiler instance - change (mediawiki...DumpHTML)

2014-09-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix: Profiler instance
..


Fix: Profiler instance

Profiler is an abstract class. Chose factory method to get an instance.

Change-Id: I38c70d6e29c8c6d5b26c2675d8813d9b463cb027
---
M dumpHTML.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Reedy: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/dumpHTML.php b/dumpHTML.php
index 762ebf2..4df07a1 100644
--- a/dumpHTML.php
+++ b/dumpHTML.php
@@ -31,7 +31,7 @@
--oom-adj set /proc//oom_adj
--show-titleswrite each article title to stdout
--munge-title   available munging algorithms: none, md5, windows
---group   use the specified user group to read articles
+   --group   use the specified user group to read articles
 
 ENDS;
 
@@ -45,8 +45,8 @@
define( 'MW_CMDLINE_CALLBACK', 'wfSetupDump' );
function wfSetupDump() {
global $wgProfileToDatabase, $wgProfileSampleRate;
+   Profiler::instance();
// Override disabled profiling in maintenance scripts
-   Profiler::setInstance( new Profiler() );
$wgProfileToDatabase = false;
$wgProfileSampleRate = 1;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/157503
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I38c70d6e29c8c6d5b26c2675d8813d9b463cb027
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/DumpHTML
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix: Profiler instance - change (mediawiki...DumpHTML)

2014-08-31 Thread Physikerwelt (Code Review) 
Physikerwelt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/157503

Change subject: Fix: Profiler instance
..

Fix: Profiler instance

Profiler is an abstract class. Chose factory method to get an instance.

Change-Id: I38c70d6e29c8c6d5b26c2675d8813d9b463cb027
---
M dumpHTML.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DumpHTML 
refs/changes/03/157503/1

diff --git a/dumpHTML.php b/dumpHTML.php
index 762ebf2..0ac3238 100644
--- a/dumpHTML.php
+++ b/dumpHTML.php
@@ -46,7 +46,7 @@
function wfSetupDump() {
global $wgProfileToDatabase, $wgProfileSampleRate;
// Override disabled profiling in maintenance scripts
-   Profiler::setInstance( new Profiler() );
+   Profiler::setInstance( Profiler::instance() );
$wgProfileToDatabase = false;
$wgProfileSampleRate = 1;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/157503
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I38c70d6e29c8c6d5b26c2675d8813d9b463cb027
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DumpHTML
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits