[MediaWiki-commits] [Gerrit] Fix JS error happening when closing use this file dialog - change (mediawiki...MultimediaViewer)

2014-03-03 Thread MarkTraceur (Code Review) 
MarkTraceur has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/116507

Change subject: Fix JS error happening when closing use this file dialog
..

Fix JS error happening when closing use this file dialog

Change-Id: I690f473ea17117bed7d30e1a858f6612f57fc33e
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/224
(cherry picked from commit 430ec53d3e24a09b0ca3dd6d583ec8e287c4722b)
---
M resources/mmv/ui/mmv.ui.fileReuse.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer 
refs/changes/07/116507/1

diff --git a/resources/mmv/ui/mmv.ui.fileReuse.js 
b/resources/mmv/ui/mmv.ui.fileReuse.js
index dbc13de..e1b6600 100644
--- a/resources/mmv/ui/mmv.ui.fileReuse.js
+++ b/resources/mmv/ui/mmv.ui.fileReuse.js
@@ -111,7 +111,7 @@
ownId = 'mw-mlb-use-file-onwiki-normal',
owId = 'mw-mlb-use-file-offwiki',
 
-   viewer = this.viewer,
+   reuse = this,
 
$owtLabel = $( 'label' )
.prop( 'for', owtId )
@@ -175,7 +175,7 @@
width: 750,
close: function () {
// Delete the dialog object
-   viewer.ui.$dialog = undefined;
+   reuse.$dialog = undefined;
}
} );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/116507
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I690f473ea17117bed7d30e1a858f6612f57fc33e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: wmf/1.23wmf16
Gerrit-Owner: MarkTraceur mtrac...@member.fsf.org
Gerrit-Reviewer: Gilles gdu...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix JS error happening when closing use this file dialog - change (mediawiki...MultimediaViewer)

2014-03-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix JS error happening when closing use this file dialog
..


Fix JS error happening when closing use this file dialog

Change-Id: I690f473ea17117bed7d30e1a858f6612f57fc33e
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/224
(cherry picked from commit 430ec53d3e24a09b0ca3dd6d583ec8e287c4722b)
---
M resources/mmv/ui/mmv.ui.fileReuse.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  MarkTraceur: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/mmv/ui/mmv.ui.fileReuse.js 
b/resources/mmv/ui/mmv.ui.fileReuse.js
index dbc13de..e1b6600 100644
--- a/resources/mmv/ui/mmv.ui.fileReuse.js
+++ b/resources/mmv/ui/mmv.ui.fileReuse.js
@@ -111,7 +111,7 @@
ownId = 'mw-mlb-use-file-onwiki-normal',
owId = 'mw-mlb-use-file-offwiki',
 
-   viewer = this.viewer,
+   reuse = this,
 
$owtLabel = $( 'label' )
.prop( 'for', owtId )
@@ -175,7 +175,7 @@
width: 750,
close: function () {
// Delete the dialog object
-   viewer.ui.$dialog = undefined;
+   reuse.$dialog = undefined;
}
} );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/116507
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I690f473ea17117bed7d30e1a858f6612f57fc33e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: wmf/1.23wmf16
Gerrit-Owner: MarkTraceur mtrac...@member.fsf.org
Gerrit-Reviewer: Gilles gdu...@wikimedia.org
Gerrit-Reviewer: MarkTraceur mtrac...@member.fsf.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix JS error happening when closing use this file dialog - change (mediawiki...MultimediaViewer)

2014-02-28 Thread Gilles (Code Review) 
Gilles has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/116074

Change subject: Fix JS error happening when closing use this file dialog
..

Fix JS error happening when closing use this file dialog

Change-Id: I690f473ea17117bed7d30e1a858f6612f57fc33e
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/224
---
M resources/mmv/ui/mmv.ui.fileReuse.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer 
refs/changes/74/116074/1

diff --git a/resources/mmv/ui/mmv.ui.fileReuse.js 
b/resources/mmv/ui/mmv.ui.fileReuse.js
index dbc13de..e1b6600 100644
--- a/resources/mmv/ui/mmv.ui.fileReuse.js
+++ b/resources/mmv/ui/mmv.ui.fileReuse.js
@@ -111,7 +111,7 @@
ownId = 'mw-mlb-use-file-onwiki-normal',
owId = 'mw-mlb-use-file-offwiki',
 
-   viewer = this.viewer,
+   reuse = this,
 
$owtLabel = $( 'label' )
.prop( 'for', owtId )
@@ -175,7 +175,7 @@
width: 750,
close: function () {
// Delete the dialog object
-   viewer.ui.$dialog = undefined;
+   reuse.$dialog = undefined;
}
} );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/116074
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I690f473ea17117bed7d30e1a858f6612f57fc33e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gilles gdu...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix JS error happening when closing use this file dialog - change (mediawiki...MultimediaViewer)

2014-02-28 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix JS error happening when closing use this file dialog
..


Fix JS error happening when closing use this file dialog

Change-Id: I690f473ea17117bed7d30e1a858f6612f57fc33e
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/224
---
M resources/mmv/ui/mmv.ui.fileReuse.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Gergő Tisza: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/mmv/ui/mmv.ui.fileReuse.js 
b/resources/mmv/ui/mmv.ui.fileReuse.js
index dbc13de..e1b6600 100644
--- a/resources/mmv/ui/mmv.ui.fileReuse.js
+++ b/resources/mmv/ui/mmv.ui.fileReuse.js
@@ -111,7 +111,7 @@
ownId = 'mw-mlb-use-file-onwiki-normal',
owId = 'mw-mlb-use-file-offwiki',
 
-   viewer = this.viewer,
+   reuse = this,
 
$owtLabel = $( 'label' )
.prop( 'for', owtId )
@@ -175,7 +175,7 @@
width: 750,
close: function () {
// Delete the dialog object
-   viewer.ui.$dialog = undefined;
+   reuse.$dialog = undefined;
}
} );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/116074
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I690f473ea17117bed7d30e1a858f6612f57fc33e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gilles gdu...@wikimedia.org
Gerrit-Reviewer: Gergő Tisza gti...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits