[MediaWiki-commits] [Gerrit] Fix Jenkins condition in entry file - change (mediawiki...Wikibase)
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176882
Change subject: Fix Jenkins condition in entry file
..
Fix Jenkins condition in entry file
Follows-up 6be762858a.
The error message was, for all intends and purposes, unreachable.
Local installs and production, naturally, don't set any non-standard
variable wgWikimediaJenkinsCI. Thus the condition was never reached.
Within Jenkins, the variable is set (with value true). Thus the
condition isn't reached there, either.
Change-Id: I29d7929aa82d5635c75bb7ea741440af0450e6e4
---
M Wikibase.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/82/176882/1
diff --git a/Wikibase.php b/Wikibase.php
index b26f47a..bd5b7eb 100644
--- a/Wikibase.php
+++ b/Wikibase.php
@@ -32,7 +32,7 @@
//TODO: Use a different file for jenkins, use this for a standard repo+client
setup.
-if( isset( $wgWikimediaJenkinsCI ) !$wgWikimediaJenkinsCI ) {
+if ( !isset( $wgWikimediaJenkinsCI ) || !$wgWikimediaJenkinsCI ) {
die( This entry point is for use by the Jenkins testing framework
only.\n
. Use repo/Wikibase.php resp. client/WikibaseClient.php
instead.\n );
}
--
To view, visit https://gerrit.wikimedia.org/r/176882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I29d7929aa82d5635c75bb7ea741440af0450e6e4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Krinkle krinklem...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Jenkins condition in entry file - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged.
Change subject: Fix Jenkins condition in entry file
..
Fix Jenkins condition in entry file
Follows-up 6be762858a.
The error message was, for all intends and purposes, unreachable.
Local installs and production, naturally, don't set any non-standard
variable wgWikimediaJenkinsCI. Thus the condition was never reached.
Within Jenkins, the variable is set (with value true). Thus the
condition isn't reached there, either.
Change-Id: I29d7929aa82d5635c75bb7ea741440af0450e6e4
---
M Wikibase.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Wikibase.php b/Wikibase.php
index b26f47a..bd5b7eb 100644
--- a/Wikibase.php
+++ b/Wikibase.php
@@ -32,7 +32,7 @@
//TODO: Use a different file for jenkins, use this for a standard repo+client
setup.
-if( isset( $wgWikimediaJenkinsCI ) !$wgWikimediaJenkinsCI ) {
+if ( !isset( $wgWikimediaJenkinsCI ) || !$wgWikimediaJenkinsCI ) {
die( This entry point is for use by the Jenkins testing framework
only.\n
. Use repo/Wikibase.php resp. client/WikibaseClient.php
instead.\n );
}
--
To view, visit https://gerrit.wikimedia.org/r/176882
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29d7929aa82d5635c75bb7ea741440af0450e6e4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Krinkle krinklem...@gmail.com
Gerrit-Reviewer: Addshore addshorew...@gmail.com
Gerrit-Reviewer: Daniel Werner daniel.a.r.wer...@gmail.com
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Krinkle krinklem...@gmail.com
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
