[MediaWiki-commits] [Gerrit] Fix Monobook skin rendering of banner - change (mediawiki...WikidataPageBanner)

2015-09-25 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix Monobook skin rendering of banner
..


Fix Monobook skin rendering of banner

Bug: T113746
Change-Id: I08915629f1d4ab8d8dfdfcc70b3a30661eb3d132
---
M includes/WikidataPageBanner.functions.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/WikidataPageBanner.functions.php 
b/includes/WikidataPageBanner.functions.php
index 20145ae..5d3cc9d 100644
--- a/includes/WikidataPageBanner.functions.php
+++ b/includes/WikidataPageBanner.functions.php
@@ -273,7 +273,7 @@
 
if ( !$doNotShow
&& in_array( $skinName, self::$blacklistSkins ) ) {
-   $out->prependHtml( $banner );
+   $out->prependHtml( $html );
}
if ( $config->get( 'WPBEnableHeadingOverride' ) && !$doNotShow 
) {
$htmlTitle = $out->getHTMLTitle();

-- 
To view, visit https://gerrit.wikimedia.org/r/241057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08915629f1d4ab8d8dfdfcc70b3a30661eb3d132
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix Monobook skin rendering of banner - change (mediawiki...WikidataPageBanner)

2015-09-25 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/241057

Change subject: Fix Monobook skin rendering of banner
..

Fix Monobook skin rendering of banner

Bug: T113746
Change-Id: I08915629f1d4ab8d8dfdfcc70b3a30661eb3d132
---
M includes/WikidataPageBanner.functions.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner 
refs/changes/57/241057/1

diff --git a/includes/WikidataPageBanner.functions.php 
b/includes/WikidataPageBanner.functions.php
index 63c8e64..5c99fd1 100644
--- a/includes/WikidataPageBanner.functions.php
+++ b/includes/WikidataPageBanner.functions.php
@@ -269,7 +269,7 @@
global $wgWPBEnableHeadingOverride;
 
if ( in_array( $out->getSkin()->getSkinName(), 
self::$blacklistSkins ) ) {
-   $out->prependHtml( $banner );
+   $out->prependHtml( $html );
}
if ( $wgWPBEnableHeadingOverride ) {
$htmlTitle = $out->getHTMLTitle();

-- 
To view, visit https://gerrit.wikimedia.org/r/241057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08915629f1d4ab8d8dfdfcc70b3a30661eb3d132
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits