[MediaWiki-commits] [Gerrit] Fix broken @see in Number(Un)Localizer doc - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review) 
Jeroen De Dauw has submitted this change and it was merged.

Change subject: Fix broken @see in Number(Un)Localizer doc
..


Fix broken @see in Number(Un)Localizer doc

Also see https://github.com/DataValues/Number/pull/14

Change-Id: Iad716fb67f14980b35ab32e2a333cfb00a8eee81
---
M lib/includes/formatters/MediaWikiNumberLocalizer.php
M lib/includes/parsers/MediaWikiNumberUnlocalizer.php
2 files changed, 11 insertions(+), 13 deletions(-)

Approvals:
  Jeroen De Dauw: Looks good to me, approved



diff --git a/lib/includes/formatters/MediaWikiNumberLocalizer.php 
b/lib/includes/formatters/MediaWikiNumberLocalizer.php
index c23eeb3..a6c0d70 100644
--- a/lib/includes/formatters/MediaWikiNumberLocalizer.php
+++ b/lib/includes/formatters/MediaWikiNumberLocalizer.php
@@ -19,7 +19,7 @@
/**
 * @var Language
 */
-   protected $language;
+   private $language;
 
/**
 * @param Language $language
@@ -29,17 +29,16 @@
}
 
/**
-* @see Localizer::localize()
+* @see NumberLocalizer::localizeNumber
 *
-* @since 0.5
+* @param string|int|float $number
 *
-* @param string $number a numeric string
-*
-* @return string
 * @throws InvalidArgumentException
+* @return string
 */
public function localizeNumber( $number ) {
-   $localiezdNumber = $this->language->formatNum( $number );
-   return $localiezdNumber;
+   $localizedNumber = $this->language->formatNum( $number );
+   return $localizedNumber;
}
+
 }
diff --git a/lib/includes/parsers/MediaWikiNumberUnlocalizer.php 
b/lib/includes/parsers/MediaWikiNumberUnlocalizer.php
index 25e91e0..691bf2e 100644
--- a/lib/includes/parsers/MediaWikiNumberUnlocalizer.php
+++ b/lib/includes/parsers/MediaWikiNumberUnlocalizer.php
@@ -1,12 +1,11 @@
 language->parseFormattedNumber( 
$number );
@@ -52,7 +51,7 @@
}
 
/**
-* @see Unlocalizer::getNumberRegex()
+* @see NumberUnlocalizer::getNumberRegex
 *
 * Constructs a regular expression based on 
Language::digitTransformTable()
 * and Language::separatorTransformTable().

-- 
To view, visit https://gerrit.wikimedia.org/r/176230
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iad716fb67f14980b35ab32e2a333cfb00a8eee81
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: JanZerebecki 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix broken @see in Number(Un)Localizer doc - change (mediawiki...Wikibase)

2014-11-27 Thread WMDE 
Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/176230

Change subject: Fix broken @see in Number(Un)Localizer doc
..

Fix broken @see in Number(Un)Localizer doc

Also see https://github.com/DataValues/Number/pull/14

Change-Id: Iad716fb67f14980b35ab32e2a333cfb00a8eee81
---
M lib/includes/formatters/MediaWikiNumberLocalizer.php
M lib/includes/parsers/MediaWikiNumberUnlocalizer.php
2 files changed, 11 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/30/176230/1

diff --git a/lib/includes/formatters/MediaWikiNumberLocalizer.php 
b/lib/includes/formatters/MediaWikiNumberLocalizer.php
index c23eeb3..a6c0d70 100644
--- a/lib/includes/formatters/MediaWikiNumberLocalizer.php
+++ b/lib/includes/formatters/MediaWikiNumberLocalizer.php
@@ -19,7 +19,7 @@
/**
 * @var Language
 */
-   protected $language;
+   private $language;
 
/**
 * @param Language $language
@@ -29,17 +29,16 @@
}
 
/**
-* @see Localizer::localize()
+* @see NumberLocalizer::localizeNumber
 *
-* @since 0.5
+* @param string|int|float $number
 *
-* @param string $number a numeric string
-*
-* @return string
 * @throws InvalidArgumentException
+* @return string
 */
public function localizeNumber( $number ) {
-   $localiezdNumber = $this->language->formatNum( $number );
-   return $localiezdNumber;
+   $localizedNumber = $this->language->formatNum( $number );
+   return $localizedNumber;
}
+
 }
diff --git a/lib/includes/parsers/MediaWikiNumberUnlocalizer.php 
b/lib/includes/parsers/MediaWikiNumberUnlocalizer.php
index 25e91e0..691bf2e 100644
--- a/lib/includes/parsers/MediaWikiNumberUnlocalizer.php
+++ b/lib/includes/parsers/MediaWikiNumberUnlocalizer.php
@@ -1,12 +1,11 @@
 language->parseFormattedNumber( 
$number );
@@ -52,7 +51,7 @@
}
 
/**
-* @see Unlocalizer::getNumberRegex()
+* @see NumberUnlocalizer::getNumberRegex
 *
 * Constructs a regular expression based on 
Language::digitTransformTable()
 * and Language::separatorTransformTable().

-- 
To view, visit https://gerrit.wikimedia.org/r/176230
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad716fb67f14980b35ab32e2a333cfb00a8eee81
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits