[MediaWiki-commits] [Gerrit] Fix callable name case mismatches - change (mediawiki...Translate)

2016-03-04 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Fix callable name case mismatches
..


Fix callable name case mismatches

Also update casing in two methods:
* MessageCollection::setInfile() -> setInFile()
* StringMangler::unMangle() -> unmangle()

Change-Id: I88bb6224700db74d35b81374a1880e45e446c028
---
M MessageCollection.php
M MessageGroups.php
M TranslateEditAddons.php
M TranslateUtils.php
M api/ApiTranslateSandbox.php
M ffs/XliffFFS.php
M messagegroups/AggregateMessageGroup.php
M messagegroups/MessageGroupBase.php
M messagegroups/MessageGroupOld.php
M messagegroups/WikiPageMessageGroup.php
M scripts/create-language-models.php
M scripts/createCheckIndex.php
M scripts/fuzzy.php
M scripts/processMessageChanges.php
M specials/SpecialAggregateGroups.php
M specials/SpecialImportTranslations.php
M specials/SpecialManageGroups.php
M specials/SpecialManageTranslatorSandbox.php
M specials/SpecialSearchTranslations.php
M specials/SpecialSupportedLanguages.php
M specials/SpecialTranslate.php
M specials/SpecialTranslationStash.php
M specials/SpecialTranslationStats.php
M stash/TranslationStashStorage.php
M stringmangler/StringMangler.php
M stringmangler/StringMatcher.php
M tag/PageTranslationHooks.php
M tag/SpecialPageTranslation.php
M tag/SpecialPageTranslationDeletePage.php
M tag/SpecialPageTranslationMovePage.php
M tag/TPParse.php
M tag/TranslatablePage.php
M tests/phpunit/MediaWikiMessageCheckerTest.php
M tests/phpunit/MessageCollectionTest.php
M tests/phpunit/SolrTTMServerTest.php
M tests/phpunit/StringMatcherTest.php
M tests/phpunit/TPParseTest.php
M tests/phpunit/ffs/MediaWikiExtensionFFSTest.php
M translationaids/SupportAid.php
M translationaids/UpdatedDefinitionAid.php
M ttmserver/CrossLanguageTranslationSearchQuery.php
M ttmserver/DatabaseTTMServer.php
M ttmserver/ElasticSearchTTMServer.php
M ttmserver/SolrTTMServer.php
M utils/Font.php
M utils/HTMLJsSelectToInputField.php
M utils/JsSelectToInput.php
M utils/MessageHandle.php
M utils/MessageIndex.php
M utils/MessageTable.php
M utils/MessageUpdateJob.php
M utils/StatsTable.php
M utils/TranslateSandbox.php
M utils/TranslationEditPage.php
M utils/TranslationHelpers.php
55 files changed, 150 insertions(+), 150 deletions(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/MessageCollection.php b/MessageCollection.php
index 0757286..e3ced0d 100644
--- a/MessageCollection.php
+++ b/MessageCollection.php
@@ -121,7 +121,7 @@
 * @param array $messages \arrayof{String,String} Array of translations 
indexed
 * by display key.
 */
-   public function setInfile( array $messages ) {
+   public function setInFile( array $messages ) {
$this->infile = $messages;
}
 
@@ -728,7 +728,7 @@
$byNamespace = array();
foreach ( $this->getTitles() as $title ) {
$namespace = $title->getNamespace();
-   $pagename = $title->getDBKey();
+   $pagename = $title->getDBkey();
$byNamespace[$namespace][] = $pagename;
}
 
@@ -776,7 +776,7 @@
 * @var Title $title
 */
foreach ( $this->keys as $mkey => $title ) {
-   $map[$title->getNamespace()][$title->getDBKey()] = 
$mkey;
+   $map[$title->getNamespace()][$title->getDBkey()] = 
$mkey;
}
 
return $this->reverseMap = $map;
diff --git a/MessageGroups.php b/MessageGroups.php
index dfb90c3..971d8f6 100644
--- a/MessageGroups.php
+++ b/MessageGroups.php
@@ -84,7 +84,7 @@
 */
public static function clearCache() {
$self = self::singleton();
-   $self->getCache()->delete( wfMemckey( 'translate-groups' ) );
+   $self->getCache()->delete( wfMemcKey( 'translate-groups' ) );
$self->groups = null;
}
 
@@ -143,7 +143,7 @@
// Register autoloaders for this request, both values modified 
by reference
self::appendAutoloader( $autoload, $wgAutoloadClasses );
 
-   $key = wfMemckey( 'translate-groups' );
+   $key = wfMemcKey( 'translate-groups' );
$value = array(
'cc' => $groups,
'autoload' => $autoload,
diff --git a/TranslateEditAddons.php b/TranslateEditAddons.php
index 148ad4d..8a3bc6d 100644
--- a/TranslateEditAddons.php
+++ b/TranslateEditAddons.php
@@ -161,7 +161,7 @@
 
// Update it.
if ( $revision === null ) {
-   $rev = $wikiPage->getTitle()->getLatestRevId();
+   $rev = $wikiPage->getTitle()->getLatestRevID();
} else {
$rev = $revision->getID();
}
@@ -341,7 +341,7 @@
ar

[MediaWiki-commits] [Gerrit] Fix callable name case mismatches - change (mediawiki...Translate)

2016-03-03 Thread Siebrand (Code Review)
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/274892

Change subject: Fix callable name case mismatches
..

Fix callable name case mismatches

Change-Id: I88bb6224700db74d35b81374a1880e45e446c028
---
M MessageCollection.php
M MessageGroups.php
M TranslateEditAddons.php
M TranslateUtils.php
M api/ApiTranslateSandbox.php
M ffs/AmdFFS.php
M ffs/AndroidXmlFFS.php
M ffs/AppleFFS.php
M ffs/DtdFFS.php
M ffs/FlatPhpFFS.php
M ffs/IniFFS.php
M ffs/JavaFFS.php
M ffs/JavaScriptFFS.php
M ffs/JsonFFS.php
M ffs/MediaWikiExtensionFFS.php
M ffs/SimpleFFS.php
M ffs/XliffFFS.php
M ffs/YamlFFS.php
M messagegroups/AggregateMessageGroup.php
M messagegroups/MessageGroupBase.php
M messagegroups/MessageGroupOld.php
M messagegroups/WikiPageMessageGroup.php
M scripts/create-language-models.php
M scripts/createCheckIndex.php
M scripts/fuzzy.php
M scripts/processMessageChanges.php
M specials/SpecialAggregateGroups.php
M specials/SpecialImportTranslations.php
M specials/SpecialManageGroups.php
M specials/SpecialManageTranslatorSandbox.php
M specials/SpecialSearchTranslations.php
M specials/SpecialSupportedLanguages.php
M specials/SpecialTranslate.php
M specials/SpecialTranslationStash.php
M specials/SpecialTranslationStats.php
M stash/TranslationStashStorage.php
M tag/PageTranslationHooks.php
M tag/SpecialPageTranslation.php
M tag/SpecialPageTranslationDeletePage.php
M tag/SpecialPageTranslationMovePage.php
M tag/TPParse.php
M tag/TranslatablePage.php
M tests/phpunit/MediaWikiMessageCheckerTest.php
M tests/phpunit/MessageCollectionTest.php
M tests/phpunit/SolrTTMServerTest.php
M tests/phpunit/StringMatcherTest.php
M tests/phpunit/TPParseTest.php
M tests/phpunit/ffs/MediaWikiExtensionFFSTest.php
M translationaids/SupportAid.php
M translationaids/UpdatedDefinitionAid.php
M ttmserver/CrossLanguageTranslationSearchQuery.php
M ttmserver/DatabaseTTMServer.php
M ttmserver/ElasticSearchTTMServer.php
M ttmserver/SolrTTMServer.php
M utils/Font.php
M utils/HTMLJsSelectToInputField.php
M utils/JsSelectToInput.php
M utils/MessageGroupStats.php
M utils/MessageHandle.php
M utils/MessageIndex.php
M utils/MessageTable.php
M utils/MessageUpdateJob.php
M utils/StatsTable.php
M utils/TranslateSandbox.php
M utils/TranslationEditPage.php
M utils/TranslationHelpers.php
66 files changed, 157 insertions(+), 157 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/92/274892/1

diff --git a/MessageCollection.php b/MessageCollection.php
index 0757286..8752f18 100644
--- a/MessageCollection.php
+++ b/MessageCollection.php
@@ -728,7 +728,7 @@
$byNamespace = array();
foreach ( $this->getTitles() as $title ) {
$namespace = $title->getNamespace();
-   $pagename = $title->getDBKey();
+   $pagename = $title->getDBkey();
$byNamespace[$namespace][] = $pagename;
}
 
@@ -776,7 +776,7 @@
 * @var Title $title
 */
foreach ( $this->keys as $mkey => $title ) {
-   $map[$title->getNamespace()][$title->getDBKey()] = 
$mkey;
+   $map[$title->getNamespace()][$title->getDBkey()] = 
$mkey;
}
 
return $this->reverseMap = $map;
diff --git a/MessageGroups.php b/MessageGroups.php
index 5595438..23671e9 100644
--- a/MessageGroups.php
+++ b/MessageGroups.php
@@ -85,7 +85,7 @@
 */
public static function clearCache() {
$self = self::singleton();
-   $self->getCache()->delete( wfMemckey( 'translate-groups' ) );
+   $self->getCache()->delete( wfMemcKey( 'translate-groups' ) );
$self->groups = null;
}
 
@@ -144,7 +144,7 @@
// Register autoloaders for this request, both values modified 
by reference
self::appendAutoloader( $autoload, $wgAutoloadClasses );
 
-   $key = wfMemckey( 'translate-groups' );
+   $key = wfMemcKey( 'translate-groups' );
$value = array(
'cc' => $groups,
'autoload' => $autoload,
diff --git a/TranslateEditAddons.php b/TranslateEditAddons.php
index 148ad4d..8a3bc6d 100644
--- a/TranslateEditAddons.php
+++ b/TranslateEditAddons.php
@@ -161,7 +161,7 @@
 
// Update it.
if ( $revision === null ) {
-   $rev = $wikiPage->getTitle()->getLatestRevId();
+   $rev = $wikiPage->getTitle()->getLatestRevID();
} else {
$rev = $revision->getID();
}
@@ -341,7 +341,7 @@
array( 'class' => 'mw-sp-translate-edit-fields' ),
$output
);
-   $out->addHtml( $output );
+   $out->addHTML( $outp