[MediaWiki-commits] [Gerrit] Fix debug log line for $userLimit. - change (mediawiki/core)

2013-04-22 Thread Daniel Kinzler (Code Review) 
Daniel Kinzler has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/60239


Change subject: Fix debug log line for $userLimit.
..

Fix debug log line for $userLimit.

$userLimit was used inline in the message, causing an array to string 
conversion
notice and a mangled log entry.

Change-Id: I8c5199f1bf01b56e955d8d15c48061b5301b1745
---
M includes/User.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/39/60239/1

diff --git a/includes/User.php b/includes/User.php
index 03e894e..e911cb0 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -1534,7 +1534,8 @@
}
// Set the user limit key
if ( $userLimit !== false ) {
-   wfDebug( __METHOD__ . : effective user limit: 
$userLimit\n );
+   list( $max, $period ) = $userLimit;
+   wfDebug( __METHOD__ . : effective user limit: $max in 
{$period}s\n );
$keys[wfMemcKey( 'limiter', $action, 'user', $id )] = 
$userLimit;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/60239
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c5199f1bf01b56e955d8d15c48061b5301b1745
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix debug log line for $userLimit. - change (mediawiki/core)

2013-04-22 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix debug log line for $userLimit.
..


Fix debug log line for $userLimit.

$userLimit was used inline in the message, causing an array to string 
conversion
notice and a mangled log entry.

Change-Id: I8c5199f1bf01b56e955d8d15c48061b5301b1745
---
M includes/User.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/User.php b/includes/User.php
index 03e894e..e911cb0 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -1534,7 +1534,8 @@
}
// Set the user limit key
if ( $userLimit !== false ) {
-   wfDebug( __METHOD__ . : effective user limit: 
$userLimit\n );
+   list( $max, $period ) = $userLimit;
+   wfDebug( __METHOD__ . : effective user limit: $max in 
{$period}s\n );
$keys[wfMemcKey( 'limiter', $action, 'user', $id )] = 
$userLimit;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/60239
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c5199f1bf01b56e955d8d15c48061b5301b1745
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de
Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org
Gerrit-Reviewer: Hashar has...@free.fr
Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits