[MediaWiki-commits] [Gerrit] Fix doc tags in EntityUsageTableBuilder - change (mediawiki...Wikibase)

2014-12-04 Thread WMDE 
Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/177537

Change subject: Fix doc tags in EntityUsageTableBuilder
..

Fix doc tags in EntityUsageTableBuilder

Change-Id: Ib4fe26631aab3c7707e1f287f45f879ee656ab58
---
M client/includes/Usage/Sql/EntityUsageTableBuilder.php
M client/tests/phpunit/includes/Usage/Sql/EntityUsageTableBuilderTest.php
2 files changed, 7 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/37/177537/1

diff --git a/client/includes/Usage/Sql/EntityUsageTableBuilder.php 
b/client/includes/Usage/Sql/EntityUsageTableBuilder.php
index c229794..25d73ed 100644
--- a/client/includes/Usage/Sql/EntityUsageTableBuilder.php
+++ b/client/includes/Usage/Sql/EntityUsageTableBuilder.php
@@ -89,7 +89,7 @@
/**
 * @param MessageReporter $progressReporter
 */
-   public function setProgressReporter( $progressReporter ) {
+   public function setProgressReporter( MessageReporter $progressReporter 
) {
$this-progressReporter = $progressReporter;
}
 
@@ -103,7 +103,7 @@
/**
 * @param ExceptionHandler $exceptionHandler
 */
-   public function setExceptionHandler( $exceptionHandler ) {
+   public function setExceptionHandler( ExceptionHandler $exceptionHandler 
) {
$this-exceptionHandler = $exceptionHandler;
}
 
@@ -224,8 +224,7 @@
$this-exceptionHandler-handleException(
$ex,
'badEntityId',
-   __METHOD__ .': ' .
-   'Failed to parse entity ID: ' .
+   __METHOD__ . ': ' . 'Failed to parse 
entity ID: ' .
$row-pp_value . ' at page ' .
$row-pp_page
);
diff --git 
a/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableBuilderTest.php 
b/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableBuilderTest.php
index 455e7f2..2a0d916 100644
--- a/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableBuilderTest.php
+++ b/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableBuilderTest.php
@@ -2,12 +2,12 @@
 
 namespace Wikibase\Client\Tests\Usage\Sql;
 
-use PHPUnit_Framework_MockObject_Matcher;
 use PHPUnit_Framework_MockObject_Matcher_Invocation;
 use Wikibase\Client\Usage\Sql\EntityUsageTableBuilder;
 use Wikibase\Client\WikibaseClient;
 use Wikibase\DataModel\Entity\BasicEntityIdParser;
 use Wikibase\Lib\Reporting\ExceptionHandler;
+use Wikibase\Lib\Reporting\MessageReporter;
 
 /**
  * @covers Wikibase\Client\Usage\Sql\EntityUsageTableBuilder
@@ -103,7 +103,7 @@
}
 
/**
-* @param PHPUnit_Framework_MockObject_Matcher $matcher
+* @param PHPUnit_Framework_MockObject_Matcher_Invocation $matcher
 *
 * @return ExceptionHandler
 */
@@ -116,9 +116,9 @@
}
 
/**
-* @param PHPUnit_Framework_MockObject_Matcher $matcher
+* @param PHPUnit_Framework_MockObject_Matcher_Invocation $matcher
 *
-* @return ExceptionHandler
+* @return MessageReporter
 */
private function getMessageReporter( 
PHPUnit_Framework_MockObject_Matcher_Invocation $matcher ) {
$mock = $this-getMock( 
'Wikibase\Lib\Reporting\MessageReporter' );

-- 
To view, visit https://gerrit.wikimedia.org/r/177537
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4fe26631aab3c7707e1f287f45f879ee656ab58
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) thiemo.maet...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix doc tags in EntityUsageTableBuilder - change (mediawiki...Wikibase)

2014-12-04 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix doc tags in EntityUsageTableBuilder
..


Fix doc tags in EntityUsageTableBuilder

Change-Id: Ib4fe26631aab3c7707e1f287f45f879ee656ab58
---
M client/includes/Usage/Sql/EntityUsageTableBuilder.php
M client/tests/phpunit/includes/Usage/Sql/EntityUsageTableBuilderTest.php
2 files changed, 7 insertions(+), 8 deletions(-)

Approvals:
  Daniel Kinzler: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/client/includes/Usage/Sql/EntityUsageTableBuilder.php 
b/client/includes/Usage/Sql/EntityUsageTableBuilder.php
index c229794..25d73ed 100644
--- a/client/includes/Usage/Sql/EntityUsageTableBuilder.php
+++ b/client/includes/Usage/Sql/EntityUsageTableBuilder.php
@@ -89,7 +89,7 @@
/**
 * @param MessageReporter $progressReporter
 */
-   public function setProgressReporter( $progressReporter ) {
+   public function setProgressReporter( MessageReporter $progressReporter 
) {
$this-progressReporter = $progressReporter;
}
 
@@ -103,7 +103,7 @@
/**
 * @param ExceptionHandler $exceptionHandler
 */
-   public function setExceptionHandler( $exceptionHandler ) {
+   public function setExceptionHandler( ExceptionHandler $exceptionHandler 
) {
$this-exceptionHandler = $exceptionHandler;
}
 
@@ -224,8 +224,7 @@
$this-exceptionHandler-handleException(
$ex,
'badEntityId',
-   __METHOD__ .': ' .
-   'Failed to parse entity ID: ' .
+   __METHOD__ . ': ' . 'Failed to parse 
entity ID: ' .
$row-pp_value . ' at page ' .
$row-pp_page
);
diff --git 
a/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableBuilderTest.php 
b/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableBuilderTest.php
index 455e7f2..2a0d916 100644
--- a/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableBuilderTest.php
+++ b/client/tests/phpunit/includes/Usage/Sql/EntityUsageTableBuilderTest.php
@@ -2,12 +2,12 @@
 
 namespace Wikibase\Client\Tests\Usage\Sql;
 
-use PHPUnit_Framework_MockObject_Matcher;
 use PHPUnit_Framework_MockObject_Matcher_Invocation;
 use Wikibase\Client\Usage\Sql\EntityUsageTableBuilder;
 use Wikibase\Client\WikibaseClient;
 use Wikibase\DataModel\Entity\BasicEntityIdParser;
 use Wikibase\Lib\Reporting\ExceptionHandler;
+use Wikibase\Lib\Reporting\MessageReporter;
 
 /**
  * @covers Wikibase\Client\Usage\Sql\EntityUsageTableBuilder
@@ -103,7 +103,7 @@
}
 
/**
-* @param PHPUnit_Framework_MockObject_Matcher $matcher
+* @param PHPUnit_Framework_MockObject_Matcher_Invocation $matcher
 *
 * @return ExceptionHandler
 */
@@ -116,9 +116,9 @@
}
 
/**
-* @param PHPUnit_Framework_MockObject_Matcher $matcher
+* @param PHPUnit_Framework_MockObject_Matcher_Invocation $matcher
 *
-* @return ExceptionHandler
+* @return MessageReporter
 */
private function getMessageReporter( 
PHPUnit_Framework_MockObject_Matcher_Invocation $matcher ) {
$mock = $this-getMock( 
'Wikibase\Lib\Reporting\MessageReporter' );

-- 
To view, visit https://gerrit.wikimedia.org/r/177537
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4fe26631aab3c7707e1f287f45f879ee656ab58
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) thiemo.maet...@wikimedia.de
Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits