[MediaWiki-commits] [Gerrit] Fix docs in PageEntityUsages - change (mediawiki...Wikibase)

2015-10-02 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix docs in PageEntityUsages
..


Fix docs in PageEntityUsages

Fix php docs in PageEntityUsages (return types)

Change-Id: I3723b6afeee89334203f9514b22b83a1e1ff2d9f
---
M client/includes/Usage/PageEntityUsages.php
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Hoo man: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/client/includes/Usage/PageEntityUsages.php 
b/client/includes/Usage/PageEntityUsages.php
index b6f7f5b..f69f71f 100644
--- a/client/includes/Usage/PageEntityUsages.php
+++ b/client/includes/Usage/PageEntityUsages.php
@@ -85,7 +85,7 @@
 *
 * @see getAspectKeys()
 *
-* string[] Sorted list of aspect names (without modifiers).
+* @return string[] Sorted list of aspect names (without modifiers).
 */
public function getAspects() {
$aspects = array();
@@ -105,7 +105,7 @@
 *
 * @see getAspects()
 *
-* string[] Sorted list of full aspect names with modifiers.
+* @return string[] Sorted list of full aspect names with modifiers.
 */
public function getAspectKeys() {
$aspects = array();
@@ -174,6 +174,9 @@
return $aspects;
}
 
+   /**
+* @return string
+*/
public function __toString() {
$s = 'Page ' . $this->getPageId() . ' uses (';
$s .= implode( '|', array_keys( $this->getUsages() ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/243136
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3723b6afeee89334203f9514b22b83a1e1ff2d9f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix docs in PageEntityUsages - change (mediawiki...Wikibase)

2015-10-02 Thread Jonas Kress (WMDE) (Code Review) 
Jonas Kress (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/243136

Change subject: Fix docs in PageEntityUsages
..

Fix docs in PageEntityUsages

Fix php docs in PageEntityUsages (return types)

Change-Id: I3723b6afeee89334203f9514b22b83a1e1ff2d9f
---
M client/includes/Usage/PageEntityUsages.php
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/36/243136/1

diff --git a/client/includes/Usage/PageEntityUsages.php 
b/client/includes/Usage/PageEntityUsages.php
index b6f7f5b..f69f71f 100644
--- a/client/includes/Usage/PageEntityUsages.php
+++ b/client/includes/Usage/PageEntityUsages.php
@@ -85,7 +85,7 @@
 *
 * @see getAspectKeys()
 *
-* string[] Sorted list of aspect names (without modifiers).
+* @return string[] Sorted list of aspect names (without modifiers).
 */
public function getAspects() {
$aspects = array();
@@ -105,7 +105,7 @@
 *
 * @see getAspects()
 *
-* string[] Sorted list of full aspect names with modifiers.
+* @return string[] Sorted list of full aspect names with modifiers.
 */
public function getAspectKeys() {
$aspects = array();
@@ -174,6 +174,9 @@
return $aspects;
}
 
+   /**
+* @return string
+*/
public function __toString() {
$s = 'Page ' . $this->getPageId() . ' uses (';
$s .= implode( '|', array_keys( $this->getUsages() ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/243136
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3723b6afeee89334203f9514b22b83a1e1ff2d9f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits