[MediaWiki-commits] [Gerrit] Fix editing header on untouched page. - change (mediawiki...Flow)

2014-03-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix editing header on untouched page.
..


Fix editing header on untouched page.

Adding BoardHistory block in I363b6bd9e972467953b0e64cd437309ce08446b7 threw an
exception if there was no history for all API calls.

Change-Id: I929e3c1f0279d7f4a986a28f73c55c0272deb3d2
---
M includes/Block/BoardHistory.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Block/BoardHistory.php b/includes/Block/BoardHistory.php
index fc83e2b..ebe809d 100644
--- a/includes/Block/BoardHistory.php
+++ b/includes/Block/BoardHistory.php
@@ -81,7 +81,7 @@
);
 
if ( !$history ) {
-   throw new InvalidDataException( 'Unable to load topic 
list history for ' . $this-workflow-getId()-getAlphadecimal(), 
'fail-load-history' );
+   return array();
}
 
// get rid of history entries user doesn't have sufficient 
permissions for

-- 
To view, visit https://gerrit.wikimedia.org/r/117819
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I929e3c1f0279d7f4a986a28f73c55c0272deb3d2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Werdna agarr...@wikimedia.org
Gerrit-Reviewer: EBernhardson ebernhard...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix editing header on untouched page. - change (mediawiki...Flow)

2014-03-09 Thread Werdna (Code Review) 
Werdna has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/117819

Change subject: Fix editing header on untouched page.
..

Fix editing header on untouched page.

Adding BoardHistory block in I363b6bd9e972467953b0e64cd437309ce08446b7 threw an
exception if there was no history for all API calls.

Change-Id: I929e3c1f0279d7f4a986a28f73c55c0272deb3d2
---
M includes/Block/BoardHistory.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/19/117819/1

diff --git a/includes/Block/BoardHistory.php b/includes/Block/BoardHistory.php
index fc83e2b..ebe809d 100644
--- a/includes/Block/BoardHistory.php
+++ b/includes/Block/BoardHistory.php
@@ -81,7 +81,7 @@
);
 
if ( !$history ) {
-   throw new InvalidDataException( 'Unable to load topic 
list history for ' . $this-workflow-getId()-getAlphadecimal(), 
'fail-load-history' );
+   return array();
}
 
// get rid of history entries user doesn't have sufficient 
permissions for

-- 
To view, visit https://gerrit.wikimedia.org/r/117819
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I929e3c1f0279d7f4a986a28f73c55c0272deb3d2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Werdna agarr...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits