[MediaWiki-commits] [Gerrit] Fix for crash if no login token retrieved. - change (apps...wikipedia)

2014-04-25 Thread Mhurd (Code Review) 
Mhurd has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/129643

Change subject: Fix for crash if no login token retrieved.
..

Fix for crash if no login token retrieved.

Change-Id: I63cd6b0910ab6d114abc5e061cac198a75d31110
---
M wikipedia/View Controllers/Login/LoginViewController.m
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/43/129643/1

diff --git a/wikipedia/View Controllers/Login/LoginViewController.m 
b/wikipedia/View Controllers/Login/LoginViewController.m
index 4be9318..7003904 100644
--- a/wikipedia/View Controllers/Login/LoginViewController.m
+++ b/wikipedia/View Controllers/Login/LoginViewController.m
@@ -263,9 +263,10 @@
NSLog(@"loginTokenOp token = %@", 
tokenRetrieved);
loginOp.token = tokenRetrieved;

-   [self logEvent: @{@"loginSessionToken": 
tokenRetrieved}
-   schema: LOG_SCHEMA_LOGIN];
-   
+   if (tokenRetrieved) {
+   [self logEvent: @{@"loginSessionToken": 
tokenRetrieved}
+   schema: LOG_SCHEMA_LOGIN];
+   }
} cancelledBlock: ^(NSError *error){

[self showAlert:@""];

-- 
To view, visit https://gerrit.wikimedia.org/r/129643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63cd6b0910ab6d114abc5e061cac198a75d31110
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix for crash if no login token retrieved. - change (apps...wikipedia)

2014-04-25 Thread Brion VIBBER (Code Review) 
Brion VIBBER has submitted this change and it was merged.

Change subject: Fix for crash if no login token retrieved.
..


Fix for crash if no login token retrieved.

Change-Id: I63cd6b0910ab6d114abc5e061cac198a75d31110
---
M wikipedia/View Controllers/Login/LoginViewController.m
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Brion VIBBER: Verified; Looks good to me, approved



diff --git a/wikipedia/View Controllers/Login/LoginViewController.m 
b/wikipedia/View Controllers/Login/LoginViewController.m
index 4be9318..7003904 100644
--- a/wikipedia/View Controllers/Login/LoginViewController.m
+++ b/wikipedia/View Controllers/Login/LoginViewController.m
@@ -263,9 +263,10 @@
NSLog(@"loginTokenOp token = %@", 
tokenRetrieved);
loginOp.token = tokenRetrieved;

-   [self logEvent: @{@"loginSessionToken": 
tokenRetrieved}
-   schema: LOG_SCHEMA_LOGIN];
-   
+   if (tokenRetrieved) {
+   [self logEvent: @{@"loginSessionToken": 
tokenRetrieved}
+   schema: LOG_SCHEMA_LOGIN];
+   }
} cancelledBlock: ^(NSError *error){

[self showAlert:@""];

-- 
To view, visit https://gerrit.wikimedia.org/r/129643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63cd6b0910ab6d114abc5e061cac198a75d31110
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd 
Gerrit-Reviewer: Brion VIBBER 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits