[MediaWiki-commits] [Gerrit] Fix form cache purging - change (mediawiki...SemanticForms)

2014-05-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix form cache purging
..


Fix form cache purging

Because we were checking the wrong variable, cached forms were not
purged on edit. Follow-up to Iec9cdb1b8390

Change-Id: I0113f407819581a4716d3b9efb20631cf6997a36
---
M includes/SF_FormUtils.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaron Koren: Checked; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/SF_FormUtils.php b/includes/SF_FormUtils.php
index 51824dd..1815d67 100644
--- a/includes/SF_FormUtils.php
+++ b/includes/SF_FormUtils.php
@@ -521,7 +521,7 @@
// get references to stored datasets
$listOfFormKeys = $cache-get( $cacheKeyForList );
 
-   if ( !is_array( $cacheKeyForList ) ) {
+   if ( !is_array( $listOfFormKeys ) ) {
return true;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/133690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0113f407819581a4716d3b9efb20631cf6997a36
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com
Gerrit-Reviewer: Yaron Koren yaro...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix form cache purging - change (mediawiki...SemanticForms)

2014-05-16 Thread Nikerabbit (Code Review) 
Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/133690

Change subject: Fix form cache purging
..

Fix form cache purging

Because we were checking the wrong variable, cached forms were not
purged on edit. Follow-up to Iec9cdb1b8390

Change-Id: I0113f407819581a4716d3b9efb20631cf6997a36
---
M includes/SF_FormUtils.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms 
refs/changes/90/133690/1

diff --git a/includes/SF_FormUtils.php b/includes/SF_FormUtils.php
index 51824dd..1815d67 100644
--- a/includes/SF_FormUtils.php
+++ b/includes/SF_FormUtils.php
@@ -521,7 +521,7 @@
// get references to stored datasets
$listOfFormKeys = $cache-get( $cacheKeyForList );
 
-   if ( !is_array( $cacheKeyForList ) ) {
+   if ( !is_array( $listOfFormKeys ) ) {
return true;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/133690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0113f407819581a4716d3b9efb20631cf6997a36
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit niklas.laxst...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits