[MediaWiki-commits] [Gerrit] Fix issue where some disambig items were not picked up - change (apps...wikipedia)

2014-11-13 Thread BearND (Code Review) 
BearND has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/173120

Change subject: Fix issue where some disambig items were not picked up
..

Fix issue where some disambig items were not picked up

This was due to an incorrect query selector used.
[[en:Test]]'s disambig link is not directly under the hatnote div.

Bug: 73393
Change-Id: I1aa2c91298bb88ac62f44882fc53323fc216c8ac
---
M wikipedia/assets/bundle.js
M wikipedia/assets/preview.js
M www/js/actions.js
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/20/173120/1

diff --git a/wikipedia/assets/bundle.js b/wikipedia/assets/bundle.js
index b1c9e0a..e0fe866 100644
--- a/wikipedia/assets/bundle.js
+++ b/wikipedia/assets/bundle.js
@@ -106,7 +106,7 @@
 
 function collectDisambig( sourceNode ) {
 var res = [];
-var links = sourceNode.querySelectorAll( 'div.hatnote  a' );
+var links = sourceNode.querySelectorAll( 'div.hatnote a' );
 var i = 0,
 len = links.length;
 for (; i  len; i++) {
diff --git a/wikipedia/assets/preview.js b/wikipedia/assets/preview.js
index 898b749..fd175a6 100644
--- a/wikipedia/assets/preview.js
+++ b/wikipedia/assets/preview.js
@@ -106,7 +106,7 @@
 
 function collectDisambig( sourceNode ) {
 var res = [];
-var links = sourceNode.querySelectorAll( 'div.hatnote  a' );
+var links = sourceNode.querySelectorAll( 'div.hatnote a' );
 var i = 0,
 len = links.length;
 for (; i  len; i++) {
diff --git a/www/js/actions.js b/www/js/actions.js
index dfcda0c..f8bc183 100644
--- a/www/js/actions.js
+++ b/www/js/actions.js
@@ -105,7 +105,7 @@
 
 function collectDisambig( sourceNode ) {
 var res = [];
-var links = sourceNode.querySelectorAll( 'div.hatnote  a' );
+var links = sourceNode.querySelectorAll( 'div.hatnote a' );
 var i = 0,
 len = links.length;
 for (; i  len; i++) {

-- 
To view, visit https://gerrit.wikimedia.org/r/173120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1aa2c91298bb88ac62f44882fc53323fc216c8ac
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND bsitzm...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix issue where some disambig items were not picked up - change (apps...wikipedia)

2014-11-13 Thread Dbrant (Code Review) 
Dbrant has submitted this change and it was merged.

Change subject: Fix issue where some disambig items were not picked up
..


Fix issue where some disambig items were not picked up

This was due to an incorrect query selector used.
[[en:Test]]'s disambig link is not directly under the hatnote div.

Bug: 73393
Change-Id: I1aa2c91298bb88ac62f44882fc53323fc216c8ac
---
M wikipedia/assets/bundle.js
M wikipedia/assets/preview.js
M www/js/actions.js
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved



diff --git a/wikipedia/assets/bundle.js b/wikipedia/assets/bundle.js
index b1c9e0a..e0fe866 100644
--- a/wikipedia/assets/bundle.js
+++ b/wikipedia/assets/bundle.js
@@ -106,7 +106,7 @@
 
 function collectDisambig( sourceNode ) {
 var res = [];
-var links = sourceNode.querySelectorAll( 'div.hatnote  a' );
+var links = sourceNode.querySelectorAll( 'div.hatnote a' );
 var i = 0,
 len = links.length;
 for (; i  len; i++) {
diff --git a/wikipedia/assets/preview.js b/wikipedia/assets/preview.js
index 898b749..fd175a6 100644
--- a/wikipedia/assets/preview.js
+++ b/wikipedia/assets/preview.js
@@ -106,7 +106,7 @@
 
 function collectDisambig( sourceNode ) {
 var res = [];
-var links = sourceNode.querySelectorAll( 'div.hatnote  a' );
+var links = sourceNode.querySelectorAll( 'div.hatnote a' );
 var i = 0,
 len = links.length;
 for (; i  len; i++) {
diff --git a/www/js/actions.js b/www/js/actions.js
index dfcda0c..f8bc183 100644
--- a/www/js/actions.js
+++ b/www/js/actions.js
@@ -105,7 +105,7 @@
 
 function collectDisambig( sourceNode ) {
 var res = [];
-var links = sourceNode.querySelectorAll( 'div.hatnote  a' );
+var links = sourceNode.querySelectorAll( 'div.hatnote a' );
 var i = 0,
 len = links.length;
 for (; i  len; i++) {

-- 
To view, visit https://gerrit.wikimedia.org/r/173120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1aa2c91298bb88ac62f44882fc53323fc216c8ac
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND bsitzm...@wikimedia.org
Gerrit-Reviewer: Brion VIBBER br...@wikimedia.org
Gerrit-Reviewer: Dbrant dbr...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits