[MediaWiki-commits] [Gerrit] Fix long line in SerializerFactoryTest - change (mediawiki...WikibaseQualityExternalValidation)

2016-01-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix long line in SerializerFactoryTest
..


Fix long line in SerializerFactoryTest

Change-Id: I570b5036e38fe203616ca72fad563478d4611dbb
---
M tests/phpunit/Serializer/SerializerFactoryTest.php
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Hoo man: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/phpunit/Serializer/SerializerFactoryTest.php 
b/tests/phpunit/Serializer/SerializerFactoryTest.php
index 80448d0..5bee5a5 100644
--- a/tests/phpunit/Serializer/SerializerFactoryTest.php
+++ b/tests/phpunit/Serializer/SerializerFactoryTest.php
@@ -100,7 +100,11 @@
 
private function buildSerializerFactory() {
$dataValueSerializer = new DataValueSerializer();
-   return new SerializerFactory( $dataValueSerializer, new 
ReferenceSerializer( new SnakListSerializer( new SnakSerializer( 
$dataValueSerializer ), false ) ) );
+   $referenceSerializer = new ReferenceSerializer(
+   new SnakListSerializer( new SnakSerializer( 
$dataValueSerializer ), false )
+   );
+
+   return new SerializerFactory( $dataValueSerializer, 
$referenceSerializer );
}
 
private function assertSerializesWithoutException( Serializer 
$serializer, $object ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/260733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I570b5036e38fe203616ca72fad563478d4611dbb
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Aude 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix long line in SerializerFactoryTest - change (mediawiki...WikibaseQualityExternalValidation)

2015-12-23 Thread Aude (Code Review) 
Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/260733

Change subject: Fix long line in SerializerFactoryTest
..

Fix long line in SerializerFactoryTest

Change-Id: I570b5036e38fe203616ca72fad563478d4611dbb
---
M tests/phpunit/Serializer/SerializerFactoryTest.php
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation
 refs/changes/33/260733/1

diff --git a/tests/phpunit/Serializer/SerializerFactoryTest.php 
b/tests/phpunit/Serializer/SerializerFactoryTest.php
index 80448d0..896c7f6 100644
--- a/tests/phpunit/Serializer/SerializerFactoryTest.php
+++ b/tests/phpunit/Serializer/SerializerFactoryTest.php
@@ -99,8 +99,11 @@
}
 
private function buildSerializerFactory() {
-   $dataValueSerializer = new DataValueSerializer();
-   return new SerializerFactory( $dataValueSerializer, new 
ReferenceSerializer( new SnakListSerializer( new SnakSerializer( 
$dataValueSerializer ), false ) ) );
+   $referenceSerializer = new ReferenceSerializer(
+   new SnakListSerializer( new SnakSerializer( new 
DataValueSerializer() ), false )
+   );
+
+   return new SerializerFactory( $dataValueSerializer, 
$referenceSeruakuzer (;
}
 
private function assertSerializesWithoutException( Serializer 
$serializer, $object ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/260733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I570b5036e38fe203616ca72fad563478d4611dbb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Aude 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits