[MediaWiki-commits] [Gerrit] Fix long lines in api EditEntityTest - change (mediawiki...Wikibase)

2016-01-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix long lines in api EditEntityTest
..


Fix long lines in api EditEntityTest

Change-Id: I5500e5bf03e985b246dd005bea96fffcf16e0974
---
M repo/tests/phpunit/includes/api/EditEntityTest.php
1 file changed, 122 insertions(+), 32 deletions(-)

Approvals:
  Hoo man: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/repo/tests/phpunit/includes/api/EditEntityTest.php 
b/repo/tests/phpunit/includes/api/EditEntityTest.php
index 0a3417d..ff47170 100644
--- a/repo/tests/phpunit/includes/api/EditEntityTest.php
+++ b/repo/tests/phpunit/includes/api/EditEntityTest.php
@@ -92,11 +92,18 @@
'p' => array( 'new' => 'property', 'data' => 
'{"datatype":"string"}' ),
'e' => array( 'type' => 'property' ) ),
'new property with data' => array( // this is our 
current example in the api doc
-   'p' => array( 'new' => 'property', 'data' => 
'{"labels":{"en-gb":{"language":"en-gb","value":"Propertylabel"}},'.
-   
'"descriptions":{"en-gb":{"language":"en-gb","value":"Propertydescription"}},"datatype":"string"}'
 ),
+   'p' => array(
+   'new' => 'property',
+   'data' => 
'{"labels":{"en-gb":{"language":"en-gb","value":"Propertylabel"}},'
+   . 
'"descriptions":{"en-gb":{"language":"en-gb","value":"Propertydescription"}},'
+   . '"datatype":"string"}'
+   ),
'e' => array( 'type' => 'property' ) ),
'add a sitelink..' => array( // make sure if we pass in 
a valid id it is accepted
-   'p' => array( 'data' => 
'{"sitelinks":{"dewiki":{"site":"dewiki","title":"TestPage!","badges":["%Q42%","%Q149%"]}}}'
 ),
+   'p' => array(
+   'data' => 
'{"sitelinks":{"dewiki":{"site":"dewiki",'
+   . 
'"title":"TestPage!","badges":["%Q42%","%Q149%"]}}}'
+   ),
'e' => array(
'sitelinks' => array(
array(
@@ -136,7 +143,10 @@
),
'remove a sitelink..' => array(
'p' => array( 'data' => 
'{"sitelinks":{"dewiki":{"site":"dewiki","title":""}}}' ),
-   'e' => array( 'labels' => array( 'en' => 'A 
Label' ), 'descriptions' => array( 'en' => 'DESC' ) ) ),
+   'e' => array(
+   'labels' => array( 'en' => 'A Label' ),
+   'descriptions' => array( 'en' => 'DESC' 
) )
+   ),
'remove a label..' => array(
'p' => array( 'data' => 
'{"labels":{"en":{"language":"en","value":""}}}' ),
'e' => array( 'descriptions' => array( 'en' => 
'DESC' ) ) ),
@@ -144,7 +154,10 @@
'p' => array( 'data' => 
'{"descriptions":{"en":{"language":"en","value":""}}}' ),
'e' => array( 'type' => 'item' ) ),
'clear an item with some new value' => array(
-   'p' => array( 'data' => 
'{"sitelinks":{"dewiki":{"site":"dewiki","title":"page"}}}', 'clear' => '' ),
+   'p' => array(
+   'data' => 
'{"sitelinks":{"dewiki":{"site":"dewiki","title":"page"}}}',
+   'clear' => ''
+   ),
'e' => array(
'type' => 'item',
'sitelinks' => array(
@@ -195,7 +208,11 @@
)
),
'unset a sitelink using the other sitelink' => array(
-   'p' => array( 'site' => 'svwiki', 'title' => 
'FOO', 'data' => '{"sitelinks":{"dewiki":{"site":"dewiki","title":""}}}' ),
+   'p' => array(
+   'site' => 'svwiki',
+   'title' => 'FOO',
+   'data' => 
'{"sitelinks":{"dewiki":{"site":"dewiki","title":""}}}'
+   ),
'e' => array(
'type' => 'item',
'sitelinks

[MediaWiki-commits] [Gerrit] Fix long lines in api EditEntityTest - change (mediawiki...Wikibase)

2016-01-18 Thread Aude (Code Review) 
Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/264923

Change subject: Fix long lines in api EditEntityTest
..

Fix long lines in api EditEntityTest

Change-Id: I5500e5bf03e985b246dd005bea96fffcf16e0974
---
M repo/tests/phpunit/includes/api/EditEntityTest.php
1 file changed, 122 insertions(+), 32 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/23/264923/1

diff --git a/repo/tests/phpunit/includes/api/EditEntityTest.php 
b/repo/tests/phpunit/includes/api/EditEntityTest.php
index 0a3417d..ff47170 100644
--- a/repo/tests/phpunit/includes/api/EditEntityTest.php
+++ b/repo/tests/phpunit/includes/api/EditEntityTest.php
@@ -92,11 +92,18 @@
'p' => array( 'new' => 'property', 'data' => 
'{"datatype":"string"}' ),
'e' => array( 'type' => 'property' ) ),
'new property with data' => array( // this is our 
current example in the api doc
-   'p' => array( 'new' => 'property', 'data' => 
'{"labels":{"en-gb":{"language":"en-gb","value":"Propertylabel"}},'.
-   
'"descriptions":{"en-gb":{"language":"en-gb","value":"Propertydescription"}},"datatype":"string"}'
 ),
+   'p' => array(
+   'new' => 'property',
+   'data' => 
'{"labels":{"en-gb":{"language":"en-gb","value":"Propertylabel"}},'
+   . 
'"descriptions":{"en-gb":{"language":"en-gb","value":"Propertydescription"}},'
+   . '"datatype":"string"}'
+   ),
'e' => array( 'type' => 'property' ) ),
'add a sitelink..' => array( // make sure if we pass in 
a valid id it is accepted
-   'p' => array( 'data' => 
'{"sitelinks":{"dewiki":{"site":"dewiki","title":"TestPage!","badges":["%Q42%","%Q149%"]}}}'
 ),
+   'p' => array(
+   'data' => 
'{"sitelinks":{"dewiki":{"site":"dewiki",'
+   . 
'"title":"TestPage!","badges":["%Q42%","%Q149%"]}}}'
+   ),
'e' => array(
'sitelinks' => array(
array(
@@ -136,7 +143,10 @@
),
'remove a sitelink..' => array(
'p' => array( 'data' => 
'{"sitelinks":{"dewiki":{"site":"dewiki","title":""}}}' ),
-   'e' => array( 'labels' => array( 'en' => 'A 
Label' ), 'descriptions' => array( 'en' => 'DESC' ) ) ),
+   'e' => array(
+   'labels' => array( 'en' => 'A Label' ),
+   'descriptions' => array( 'en' => 'DESC' 
) )
+   ),
'remove a label..' => array(
'p' => array( 'data' => 
'{"labels":{"en":{"language":"en","value":""}}}' ),
'e' => array( 'descriptions' => array( 'en' => 
'DESC' ) ) ),
@@ -144,7 +154,10 @@
'p' => array( 'data' => 
'{"descriptions":{"en":{"language":"en","value":""}}}' ),
'e' => array( 'type' => 'item' ) ),
'clear an item with some new value' => array(
-   'p' => array( 'data' => 
'{"sitelinks":{"dewiki":{"site":"dewiki","title":"page"}}}', 'clear' => '' ),
+   'p' => array(
+   'data' => 
'{"sitelinks":{"dewiki":{"site":"dewiki","title":"page"}}}',
+   'clear' => ''
+   ),
'e' => array(
'type' => 'item',
'sitelinks' => array(
@@ -195,7 +208,11 @@
)
),
'unset a sitelink using the other sitelink' => array(
-   'p' => array( 'site' => 'svwiki', 'title' => 
'FOO', 'data' => '{"sitelinks":{"dewiki":{"site":"dewiki","title":""}}}' ),
+   'p' => array(
+   'site' => 'svwiki',
+   'title' => 'FOO',
+   'data' => 
'{"sitelinks":{"dewiki":{"site":"dewiki","title":""}}}'
+   ),
'e' => array(
'type' => 'item'