[MediaWiki-commits] [Gerrit] Fix missing message in Skin.js license generation - change (mediawiki...MobileFrontend)
jenkins-bot has submitted this change and it was merged. Change subject: Fix missing message in Skin.js license generation .. Fix missing message in Skin.js license generation mobile-frontend-editor-terms-link is used in Skin.js, but is loaded in other modules only. Fix it by loading it in Skin.js module only. Bug: T104754 Change-Id: I1234137330632392f7843aaf600a5d5dcaeeeb30 --- M includes/Resources.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified Objections: Phuedx: There's a problem with this change, please improve diff --git a/includes/Resources.php b/includes/Resources.php index f5ebd24..d92732a 100644 --- a/includes/Resources.php +++ b/includes/Resources.php @@ -516,6 +516,8 @@ // icons.js 'mobile-frontend-loading-message', 'mobile-frontend-console-recruit', + // Skin.js + 'mobile-frontend-editor-terms-link', ), 'styles' => array( 'resources/mobile.startup/panel.less', @@ -663,7 +665,6 @@ 'mobile-frontend-editor-keep-editing', 'mobile-frontend-editor-licensing', 'mobile-frontend-editor-licensing-with-terms', - 'mobile-frontend-editor-terms-link', 'mobile-frontend-editor-placeholder', 'mobile-frontend-editor-placeholder-new-page', 'mobile-frontend-editor-summary', @@ -814,7 +815,6 @@ 'mobile-frontend-editor-cancel-confirm', 'mobile-frontend-editor-error', 'mobile-frontend-editor-error-conflict', - 'mobile-frontend-editor-terms-link', ), ), -- To view, visit https://gerrit.wikimedia.org/r/222730 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1234137330632392f7843aaf600a5d5dcaeeeb30 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow Gerrit-Reviewer: BarryTheBrowserTestBot Gerrit-Reviewer: Florianschmidtwelzow Gerrit-Reviewer: Jdlrobson Gerrit-Reviewer: Phuedx Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix missing message in Skin.js license generation - change (mediawiki...MobileFrontend)
Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/222730 Change subject: Fix missing message in Skin.js license generation .. Fix missing message in Skin.js license generation mobile-frontend-editor-terms-link is used in Skin.js, bjt is loaded in other modules only. fox it by loading it in Skin.js module only. Change-Id: I1234137330632392f7843aaf600a5d5dcaeeeb30 --- M includes/Resources.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/30/222730/1 diff --git a/includes/Resources.php b/includes/Resources.php index f5ebd24..d92732a 100644 --- a/includes/Resources.php +++ b/includes/Resources.php @@ -516,6 +516,8 @@ // icons.js 'mobile-frontend-loading-message', 'mobile-frontend-console-recruit', + // Skin.js + 'mobile-frontend-editor-terms-link', ), 'styles' => array( 'resources/mobile.startup/panel.less', @@ -663,7 +665,6 @@ 'mobile-frontend-editor-keep-editing', 'mobile-frontend-editor-licensing', 'mobile-frontend-editor-licensing-with-terms', - 'mobile-frontend-editor-terms-link', 'mobile-frontend-editor-placeholder', 'mobile-frontend-editor-placeholder-new-page', 'mobile-frontend-editor-summary', @@ -814,7 +815,6 @@ 'mobile-frontend-editor-cancel-confirm', 'mobile-frontend-editor-error', 'mobile-frontend-editor-error-conflict', - 'mobile-frontend-editor-terms-link', ), ), -- To view, visit https://gerrit.wikimedia.org/r/222730 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1234137330632392f7843aaf600a5d5dcaeeeb30 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
