[MediaWiki-commits] [Gerrit] Fixed "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE" memca... - change (mediawiki...PageTriage)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Fixed "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE" 
memcached errors
..


Fixed "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE" memcached errors

Change-Id: Id47395f17df1b34c2f96da3168c181d0ccd93f0a
---
M PageTriage.php
M includes/PageTriageUtil.php
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/PageTriage.php b/PageTriage.php
index 15c0af7..de4166b 100644
--- a/PageTriage.php
+++ b/PageTriage.php
@@ -82,7 +82,7 @@
'namespace' => array( NS_MAIN, NS_USER ),
),
 );
-$wgPageTriageCacheVersion = '1.3'; // version number to be added to cache key 
so that cache can be refreshed easily
+$wgPageTriageCacheVersion = '1.4'; // version number to be added to cache key 
so that cache can be refreshed easily
 $wgPageTriageNamespaces = array( NS_MAIN, NS_USER  ); // only include these 
namespaces for pagetriage
 $wgTalkPageNoteTemplate = array(
'Mark' => 'Reviewednote-NPF',
diff --git a/includes/PageTriageUtil.php b/includes/PageTriageUtil.php
index dfd98ae..e2d5446 100644
--- a/includes/PageTriageUtil.php
+++ b/includes/PageTriageUtil.php
@@ -249,12 +249,12 @@
}
 
/**
-* returns the cahce key for user status
+* returns the cache key for user status
 * @param $userName string
 * @return string
 */
public static function userStatusKey( $userName ) {
-   return wfMemcKey( 'pagetriage', 'user-page-status', $userName, 
self::getCacheVersion() );
+   return wfMemcKey( 'pagetriage', 'user-page-status', sha1( 
$userName ), self::getCacheVersion() );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/84675
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id47395f17df1b34c2f96da3168c181d0ccd93f0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixed "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE" memca... - change (mediawiki...PageTriage)

[Aaron Schulz (Code Review)]

Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/84675


Change subject: Fixed "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE" 
memcached errors
..

Fixed "A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE" memcached errors

Change-Id: Id47395f17df1b34c2f96da3168c181d0ccd93f0a
---
M PageTriage.php
M includes/PageTriageUtil.php
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage 
refs/changes/75/84675/1

diff --git a/PageTriage.php b/PageTriage.php
index 15c0af7..de4166b 100644
--- a/PageTriage.php
+++ b/PageTriage.php
@@ -82,7 +82,7 @@
'namespace' => array( NS_MAIN, NS_USER ),
),
 );
-$wgPageTriageCacheVersion = '1.3'; // version number to be added to cache key 
so that cache can be refreshed easily
+$wgPageTriageCacheVersion = '1.4'; // version number to be added to cache key 
so that cache can be refreshed easily
 $wgPageTriageNamespaces = array( NS_MAIN, NS_USER  ); // only include these 
namespaces for pagetriage
 $wgTalkPageNoteTemplate = array(
'Mark' => 'Reviewednote-NPF',
diff --git a/includes/PageTriageUtil.php b/includes/PageTriageUtil.php
index dfd98ae..e2d5446 100644
--- a/includes/PageTriageUtil.php
+++ b/includes/PageTriageUtil.php
@@ -249,12 +249,12 @@
}
 
/**
-* returns the cahce key for user status
+* returns the cache key for user status
 * @param $userName string
 * @return string
 */
public static function userStatusKey( $userName ) {
-   return wfMemcKey( 'pagetriage', 'user-page-status', $userName, 
self::getCacheVersion() );
+   return wfMemcKey( 'pagetriage', 'user-page-status', sha1( 
$userName ), self::getCacheVersion() );
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/84675
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id47395f17df1b34c2f96da3168c181d0ccd93f0a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits