[MediaWiki-commits] [Gerrit] Fixed can't modify frozen String (RuntimeError) error - change (mediawiki...ContentTranslation)
Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/130319 Change subject: Fixed can't modify frozen String (RuntimeError) error .. Fixed can't modify frozen String (RuntimeError) error See https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests- ContentTranslation-language-stage.wmflabs.org-linux-firefox/18/consoleFu ll Change-Id: I079be2ca4a53d0e86fe6158875dbec407eb11fdc --- M tests/browser/features/step_definitions/special_content_translation_steps.rb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation refs/changes/19/130319/1 diff --git a/tests/browser/features/step_definitions/special_content_translation_steps.rb b/tests/browser/features/step_definitions/special_content_translation_steps.rb index 82bc24b..6aaf192 100644 --- a/tests/browser/features/step_definitions/special_content_translation_steps.rb +++ b/tests/browser/features/step_definitions/special_content_translation_steps.rb @@ -85,7 +85,7 @@ end Then(/^I see the username at the top of the page$/) do - on(ContentTranslationPage).user_name_element.text.should == ENV[MEDIAWIKI_USER].gsub!(/_/, ' ') + on(ContentTranslationPage).user_name_element.text.should == ENV[MEDIAWIKI_USER] end Then(/^the content of the page is (.*?)$/) do |page_content| -- To view, visit https://gerrit.wikimedia.org/r/130319 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I079be2ca4a53d0e86fe6158875dbec407eb11fdc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Zfilipin zfili...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed can't modify frozen String (RuntimeError) error - change (mediawiki...ContentTranslation)
jenkins-bot has submitted this change and it was merged. Change subject: Fixed can't modify frozen String (RuntimeError) error .. Fixed can't modify frozen String (RuntimeError) error See https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-ContentTranslation-language-stage.wmflabs.org-linux-firefox/18/consoleFull Change-Id: I079be2ca4a53d0e86fe6158875dbec407eb11fdc --- M tests/browser/features/step_definitions/special_content_translation_steps.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: KartikMistry: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/special_content_translation_steps.rb b/tests/browser/features/step_definitions/special_content_translation_steps.rb index 82bc24b..6aaf192 100644 --- a/tests/browser/features/step_definitions/special_content_translation_steps.rb +++ b/tests/browser/features/step_definitions/special_content_translation_steps.rb @@ -85,7 +85,7 @@ end Then(/^I see the username at the top of the page$/) do - on(ContentTranslationPage).user_name_element.text.should == ENV[MEDIAWIKI_USER].gsub!(/_/, ' ') + on(ContentTranslationPage).user_name_element.text.should == ENV[MEDIAWIKI_USER] end Then(/^the content of the page is (.*?)$/) do |page_content| -- To view, visit https://gerrit.wikimedia.org/r/130319 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I079be2ca4a53d0e86fe6158875dbec407eb11fdc Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Zfilipin zfili...@wikimedia.org Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il Gerrit-Reviewer: Cmcmahon cmcma...@wikimedia.org Gerrit-Reviewer: Hashar has...@free.fr Gerrit-Reviewer: KartikMistry kartik.mis...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
