[MediaWiki-commits] [Gerrit] Fixed creating an empty entity - change (mediawiki...WikibaseJavaScriptApi)

2014-12-16 Thread WMDE 
Thiemo Mättig (WMDE) has submitted this change and it was merged.

Change subject: Fixed creating an empty entity
..


Fixed creating an empty entity

Change-Id: Ib26abf43cd8edf5412c9867d2fc30fded850d162
---
M README.md
M src/RepoApi.js
2 files changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Thiemo Mättig (WMDE): Verified; Looks good to me, approved



diff --git a/README.md b/README.md
index 8c60801..57088c8 100644
--- a/README.md
+++ b/README.md
@@ -7,6 +7,9 @@
  Enhancements
 * Updated code documentation to be able to generate documentation using JSDuck.
 
+### Bugfixes
+* An empty `Entity` may be created by omitting the `data` parameter on 
`wikibase.api.RepoApi.createEntity()` again.
+
 ### 1.0.1 (2014-11-28)
 
 * Bump the data-values/javascript dependency to 0.6.0 so that it matches 
Wikibase.git's.
diff --git a/src/RepoApi.js b/src/RepoApi.js
index f90a70c..d688ca8 100644
--- a/src/RepoApi.js
+++ b/src/RepoApi.js
@@ -45,7 +45,7 @@
 * @see wikibase.api.RepoApi._post
 *
 * @param {string} type The type of the `Entity` that should be created.
-* @param {Object} [data] The `Entity` data (may be omitted to create 
an empty `Entity`).
+* @param {Object} [data={}] The `Entity` data (may be omitted to 
create an empty `Entity`).
 * @return {Object} jQuery.Promise
 * @return {Function} return.done
 * @return {*} return.done.result
@@ -57,8 +57,8 @@
createEntity: function( type, data ) {
var params = {
action: 'wbeditentity',
-   data: JSON.stringify( data ),
-   'new': type
+   'new': type,
+   data: JSON.stringify( data || {} )
};
return this._post( params );
},

-- 
To view, visit https://gerrit.wikimedia.org/r/177502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib26abf43cd8edf5412c9867d2fc30fded850d162
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/WikibaseJavaScriptApi
Gerrit-Branch: master
Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de
Gerrit-Reviewer: Thiemo Mättig (WMDE) thiemo.maet...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixed creating an empty entity - change (mediawiki...WikibaseJavaScriptApi)

2014-12-04 Thread Henning Snater (Code Review) 
Henning Snater has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/177502

Change subject: Fixed creating an empty entity
..

Fixed creating an empty entity

Change-Id: Ib26abf43cd8edf5412c9867d2fc30fded850d162
---
M src/RepoApi.js
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseJavaScriptApi 
refs/changes/02/177502/1

diff --git a/src/RepoApi.js b/src/RepoApi.js
index 29f0161..30ce7c8 100644
--- a/src/RepoApi.js
+++ b/src/RepoApi.js
@@ -45,7 +45,7 @@
 * @see wikibase.api.RepoApi._post
 *
 * @param {string} type The type of the `Entity` that should be created.
-* @param {Object} [data] The `Entity` data (may be omitted to create 
an empty `Entity`).
+* @param {Object} [data={}] The `Entity` data (may be omitted to 
create an empty `Entity`).
 * @return {Object} jQuery.Promise
 * @return {Function} return.done
 * @return {*} return.done.result
@@ -57,9 +57,10 @@
createEntity: function( type, data ) {
var params = {
action: 'wbeditentity',
-   data: JSON.stringify( data ),
-   'new': type
+   'new': type,
+   data: JSON.stringify( data || {} )
};
+
return this._post( params );
},
 
@@ -439,7 +440,7 @@
 * @param {string} [claimGuid] GUID of the `Claim` to return. Either 
`claimGuid` or `entityID`
 *has to be provided.
 * @param {string} [rank] Only return `Claim`s of this `rank`.
-* @param {string} [props] Parts of the `Claim`s to return.
+* @param {string} [props] Specific parts of the `Claim`s to include in 
the response.
 * @return {Object} jQuery.Promise
 * @return {Function} return.done
 * @return {*} return.done.result

-- 
To view, visit https://gerrit.wikimedia.org/r/177502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib26abf43cd8edf5412c9867d2fc30fded850d162
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseJavaScriptApi
Gerrit-Branch: master
Gerrit-Owner: Henning Snater henning.sna...@wikimedia.de

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits