[MediaWiki-commits] [Gerrit] Fixed return value for RedisBagOStuff::cas(). - change (mediawiki/core)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/60582 Change subject: Fixed return value for RedisBagOStuff::cas(). .. Fixed return value for RedisBagOStuff::cas(). Change-Id: I3b180baaba8fb12ab2960e358c8b6d1a1eac05dd --- M includes/objectcache/RedisBagOStuff.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/82/60582/1 diff --git a/includes/objectcache/RedisBagOStuff.php b/includes/objectcache/RedisBagOStuff.php index f9feaf9..1f64b69 100644 --- a/includes/objectcache/RedisBagOStuff.php +++ b/includes/objectcache/RedisBagOStuff.php @@ -140,7 +140,7 @@ $conn->setex( $key, $expiry, $value ); } - $result = $conn->exec(); + $result = ( $conn->exec() == array( true ) ); } catch ( RedisException $e ) { $result = false; $this->handleException( $server, $conn, $e ); -- To view, visit https://gerrit.wikimedia.org/r/60582 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3b180baaba8fb12ab2960e358c8b6d1a1eac05dd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed return value for RedisBagOStuff::cas(). - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged. Change subject: Fixed return value for RedisBagOStuff::cas(). .. Fixed return value for RedisBagOStuff::cas(). Change-Id: I3b180baaba8fb12ab2960e358c8b6d1a1eac05dd --- M includes/objectcache/RedisBagOStuff.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Matthias Mullie: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/objectcache/RedisBagOStuff.php b/includes/objectcache/RedisBagOStuff.php index f9feaf9..1f64b69 100644 --- a/includes/objectcache/RedisBagOStuff.php +++ b/includes/objectcache/RedisBagOStuff.php @@ -140,7 +140,7 @@ $conn->setex( $key, $expiry, $value ); } - $result = $conn->exec(); + $result = ( $conn->exec() == array( true ) ); } catch ( RedisException $e ) { $result = false; $this->handleException( $server, $conn, $e ); -- To view, visit https://gerrit.wikimedia.org/r/60582 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b180baaba8fb12ab2960e358c8b6d1a1eac05dd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz Gerrit-Reviewer: Matthias Mullie Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits