[MediaWiki-commits] [Gerrit] Fixed template meta-wrapping to handle nesting and attribute... - change (mediawiki...Parsoid[master])

2012-08-19 Thread Subramanya Sastry (Code Review) 
Subramanya Sastry has uploaded a new change for review.

Change subject: Fixed template meta-wrapping to handle nesting and attributes.
..

Fixed template meta-wrapping to handle nesting and attributes.

* Nested parser functions are no longer meta-wrapped similar to
  nested templates.
* HTML attributes which derive all or part of their key/value
  from a template are not template-wrapped, but are marked to
  be tracked via different rdfa meta attributes.  The actual
  tracking and addition of new meta attrs. is yet to be
  implemented.
* Parser pipeline construction updated to use an options object
  rather than individual option args -- used to support the two
  features above.
* With this fix, we can now distinguish between the following
  scenarios:

  Templates:
  - {{echo|[[Foo|bar]]}} -- regular wrapping of the entire link
  - [[{{echo|Foo}}|bar]] -- no wrapping, but href marked for tracking
  - [[Foo|{{echo|bar}}]] -- link text is wrapped.

  Parser functions:
  - {{uc:foo}} -- regular wrapping.
  - {{uc:{{lc:{{uc:foo}} -- only the top-level parser function
is wrapped, the nested lc and uc parser functions are not.

Change-Id: I512b8de9838ad42d9255ebcd73074b3898294cd8
---
M js/lib/ext.core.NoIncludeOnly.js
M js/lib/ext.core.TemplateHandler.js
M js/lib/mediawiki.TokenTransformManager.js
M js/lib/mediawiki.parser.js
M js/lib/mediawiki.tokenizer.peg.js
5 files changed, 101 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/51/20651/1
--
To view, visit https://gerrit.wikimedia.org/r/20651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I512b8de9838ad42d9255ebcd73074b3898294cd8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry ssas...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fixed template meta-wrapping to handle nesting and attribute... - change (mediawiki...Parsoid[master])

2012-08-19 Thread GWicke (Code Review) 
GWicke has submitted this change and it was merged.

Change subject: Fixed template meta-wrapping to handle nesting and attributes.
..


Fixed template meta-wrapping to handle nesting and attributes.

* Nested parser functions are no longer meta-wrapped similar to
  nested templates.
* HTML attributes which derive all or part of their key/value
  from a template are not template-wrapped, but are marked to
  be tracked via different rdfa meta attributes.  The actual
  tracking and addition of new meta attrs. is yet to be
  implemented.
* Parser pipeline construction updated to use an options object
  rather than individual option args -- used to support the two
  features above.
* With this fix, we can now distinguish between the following
  scenarios:

  Templates:
  - {{echo|[[Foo|bar]]}} -- regular wrapping of the entire link
  - [[{{echo|Foo}}|bar]] -- no wrapping, but href marked for tracking
  - [[Foo|{{echo|bar}}]] -- link text is wrapped.

  Parser functions:
  - {{uc:foo}} -- regular wrapping.
  - {{uc:{{lc:{{uc:foo}} -- only the top-level parser function
is wrapped, the nested lc and uc parser functions are not.

Change-Id: I512b8de9838ad42d9255ebcd73074b3898294cd8
---
M js/lib/ext.Cite.js
M js/lib/ext.core.BehaviorSwitchHandler.js
M js/lib/ext.core.LinkHandler.js
M js/lib/ext.core.NoIncludeOnly.js
M js/lib/ext.core.TemplateHandler.js
M js/lib/mediawiki.TokenTransformManager.js
M js/lib/mediawiki.parser.js
M js/lib/mediawiki.tokenizer.peg.js
8 files changed, 113 insertions(+), 50 deletions(-)

Approvals:
  GWicke: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/20651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I512b8de9838ad42d9255ebcd73074b3898294cd8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry ssas...@wikimedia.org
Gerrit-Reviewer: GWicke gwi...@wikimedia.org
Gerrit-Reviewer: Subramanya Sastry ssas...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits