[MediaWiki-commits] [Gerrit] Followup 682b4d0b88: bring this.isSetup back - change (VisualEditor/VisualEditor)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/134937 Change subject: Followup 682b4d0b88: bring this.isSetup back .. Followup 682b4d0b88: bring this.isSetup back 682b4d0b88 removed the only line of code in ve.ce.ProtectedNode that set this.isSetup to true. Consequently, it was always false, and onProtectedTeardown would always short-circuit, so no ProtectedNode would ever get torn down, which resulted in the expected chaos of JS errors from event handlers that were never unbound. Change-Id: Icc1748fd5acab4d97e80c88c3336e9d42b70e7ad --- M modules/ve/ce/ve.ce.ProtectedNode.js 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/37/134937/1 diff --git a/modules/ve/ce/ve.ce.ProtectedNode.js b/modules/ve/ce/ve.ce.ProtectedNode.js index 9c3ba6e..68babdb 100644 --- a/modules/ve/ce/ve.ce.ProtectedNode.js +++ b/modules/ve/ce/ve.ce.ProtectedNode.js @@ -83,6 +83,8 @@ 'mouseenter.ve-ce-protectedNode': ve.bind( this.onProtectedMouseEnter, this ), 'mousedown.ve-ce-protectedNode': ve.bind( this.onProtectedMouseDown, this ) } ); + + this.isSetup = true; }; /** -- To view, visit https://gerrit.wikimedia.org/r/134937 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icc1748fd5acab4d97e80c88c3336e9d42b70e7ad Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope roan.katt...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Followup 682b4d0b88: bring this.isSetup back - change (VisualEditor/VisualEditor)
jenkins-bot has submitted this change and it was merged. Change subject: Followup 682b4d0b88: bring this.isSetup back .. Followup 682b4d0b88: bring this.isSetup back 682b4d0b88 removed the only line of code in ve.ce.ProtectedNode that set this.isSetup to true. Consequently, it was always false, and onProtectedTeardown would always short-circuit, so no ProtectedNode would ever get torn down, which resulted in the expected chaos of JS errors from event handlers that were never unbound. Change-Id: Icc1748fd5acab4d97e80c88c3336e9d42b70e7ad --- M modules/ve/ce/ve.ce.ProtectedNode.js 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jforrester: Looks good to me, but someone else must approve Esanders: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve/ce/ve.ce.ProtectedNode.js b/modules/ve/ce/ve.ce.ProtectedNode.js index 9c3ba6e..68babdb 100644 --- a/modules/ve/ce/ve.ce.ProtectedNode.js +++ b/modules/ve/ce/ve.ce.ProtectedNode.js @@ -83,6 +83,8 @@ 'mouseenter.ve-ce-protectedNode': ve.bind( this.onProtectedMouseEnter, this ), 'mousedown.ve-ce-protectedNode': ve.bind( this.onProtectedMouseDown, this ) } ); + + this.isSetup = true; }; /** -- To view, visit https://gerrit.wikimedia.org/r/134937 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc1748fd5acab4d97e80c88c3336e9d42b70e7ad Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope roan.katt...@gmail.com Gerrit-Reviewer: Esanders esand...@wikimedia.org Gerrit-Reviewer: Jforrester jforres...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
