[MediaWiki-commits] [Gerrit] Followup I15843fab: don't show page=1 in file link - change (mediawiki/core[master])
Aaron Schulz has submitted this change and it was merged. Change subject: Followup I15843fab: don't show page=1 in file link .. Followup I15843fab: don't show page=1 in file link By standardising the file parameters were handed around, the normalised parameter page (set to 1) is being passed to the linker. Since it's the default, I don't think we really need it in the link, where it is (a) meaningless and (b) confusing, since it is set for some media types that don't even have pages (e.g. SVGs). Change-Id: Ib80a85125366ec32ab05b061b06d28144dc244fc --- M includes/media/MediaTransformOutput.php 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/28452 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib80a85125366ec32ab05b061b06d28144dc244fc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Jarry1250 jarry1...@gmail.com Gerrit-Reviewer: Aaron Schulz asch...@wikimedia.org Gerrit-Reviewer: Umherirrender umherirrender_de...@web.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Followup I15843fab: don't show page=1 in file link - change (mediawiki/core[master])
Jarry1250 has uploaded a new change for review. Change subject: Followup I15843fab: don't show page=1 in file link .. Followup I15843fab: don't show page=1 in file link By standardising the file parameters were handed around, the normalised parameter page (set to 1) is being passed to the linker. Since it's the default, I don't think we really need it in the link, where it is (a) meaningless and (b) confusing, since it is set for some media types that don't even have pages (e.g. SVGs). Change-Id: Ib80a85125366ec32ab05b061b06d28144dc244fc --- M includes/media/MediaTransformOutput.php 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/52/28452/1 -- To view, visit https://gerrit.wikimedia.org/r/28452 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib80a85125366ec32ab05b061b06d28144dc244fc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Jarry1250 jarry1...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
