[MediaWiki-commits] [Gerrit] Force LTR direction in MWSyntaxHighlightDialog - change (mediawiki...VisualEditor)

2013-11-08 Thread Mooeypoo (Code Review) 
Mooeypoo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/94424


Change subject: Force LTR direction in MWSyntaxHighlightDialog
..

Force LTR direction in MWSyntaxHighlightDialog

Syntax highlight editor shouldn't rely on GUI language directionality
but always allow for LTR text editing.

Bug: 56780
Change-Id: Iae7f9eee20ffb9a003830503865458918f5e1df3
---
M modules/syntaxhighlight/styles/ve.ui.MWSyntaxHighlight.css
M modules/syntaxhighlight/ve.ui.MWSyntaxHighlightSimpleSurface.js
2 files changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/24/94424/1

diff --git a/modules/syntaxhighlight/styles/ve.ui.MWSyntaxHighlight.css 
b/modules/syntaxhighlight/styles/ve.ui.MWSyntaxHighlight.css
index f1685ff..11e41f0 100644
--- a/modules/syntaxhighlight/styles/ve.ui.MWSyntaxHighlight.css
+++ b/modules/syntaxhighlight/styles/ve.ui.MWSyntaxHighlight.css
@@ -90,7 +90,9 @@
bottom: 0;
 }
 
+/* @noflip */
 .ve-ui-simplesurface-container-editbox {
+   direction: ltr;
-webkit-touch-callout: none;
-webkit-user-select: none;
-khtml-user-select: none;
@@ -107,6 +109,7 @@
cursor: text;
 }
 
+/* @noflip */
 .ve-ui-simplesurface-textarea {
display:inline-block;
overflow: hidden;
@@ -116,6 +119,8 @@
left: -10px;
top: 0;
 }
+
+/* @noflip */
 .ve-ui-simplesurface-container-editbox pre {
border: none;
background-color: transparent;
@@ -132,12 +137,14 @@
font-size: 1.25em;
 }
 
+/* @noflip */
 .ve-ui-simplesurface-container-editbox-lineNumber {
display: inline-block;
float: left;
height: 100%;
 }
 
+/* @noflip */
 .ve-ui-simplesurface-container-editbox-text {
display: inline-block;
position: absolute;
diff --git a/modules/syntaxhighlight/ve.ui.MWSyntaxHighlightSimpleSurface.js 
b/modules/syntaxhighlight/ve.ui.MWSyntaxHighlightSimpleSurface.js
index c4277b3..a40cafa 100644
--- a/modules/syntaxhighlight/ve.ui.MWSyntaxHighlightSimpleSurface.js
+++ b/modules/syntaxhighlight/ve.ui.MWSyntaxHighlightSimpleSurface.js
@@ -126,6 +126,7 @@
);
this.$editboxLayer
.addClass( 've-ui-simplesurface-container-editbox' )
+   .addClass( 'oo-ui-ltr' )
.append( this.$lineNumberLayer
.addClass( 
've-ui-simplesurface-container-editbox-lineNumber' )
.append( this.$lineNumber

-- 
To view, visit https://gerrit.wikimedia.org/r/94424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae7f9eee20ffb9a003830503865458918f5e1df3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo mor...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Force LTR direction in MWSyntaxHighlightDialog - change (mediawiki...VisualEditor)

2013-11-08 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Force LTR direction in MWSyntaxHighlightDialog
..


Force LTR direction in MWSyntaxHighlightDialog

Syntax highlight editor shouldn't rely on GUI language directionality
but always allow for LTR text editing.

Bug: 56780
Change-Id: Iae7f9eee20ffb9a003830503865458918f5e1df3
---
M modules/syntaxhighlight/styles/ve.ui.MWSyntaxHighlight.css
M modules/syntaxhighlight/ve.ui.MWSyntaxHighlightSimpleSurface.js
2 files changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/syntaxhighlight/styles/ve.ui.MWSyntaxHighlight.css 
b/modules/syntaxhighlight/styles/ve.ui.MWSyntaxHighlight.css
index f1685ff..11e41f0 100644
--- a/modules/syntaxhighlight/styles/ve.ui.MWSyntaxHighlight.css
+++ b/modules/syntaxhighlight/styles/ve.ui.MWSyntaxHighlight.css
@@ -90,7 +90,9 @@
bottom: 0;
 }
 
+/* @noflip */
 .ve-ui-simplesurface-container-editbox {
+   direction: ltr;
-webkit-touch-callout: none;
-webkit-user-select: none;
-khtml-user-select: none;
@@ -107,6 +109,7 @@
cursor: text;
 }
 
+/* @noflip */
 .ve-ui-simplesurface-textarea {
display:inline-block;
overflow: hidden;
@@ -116,6 +119,8 @@
left: -10px;
top: 0;
 }
+
+/* @noflip */
 .ve-ui-simplesurface-container-editbox pre {
border: none;
background-color: transparent;
@@ -132,12 +137,14 @@
font-size: 1.25em;
 }
 
+/* @noflip */
 .ve-ui-simplesurface-container-editbox-lineNumber {
display: inline-block;
float: left;
height: 100%;
 }
 
+/* @noflip */
 .ve-ui-simplesurface-container-editbox-text {
display: inline-block;
position: absolute;
diff --git a/modules/syntaxhighlight/ve.ui.MWSyntaxHighlightSimpleSurface.js 
b/modules/syntaxhighlight/ve.ui.MWSyntaxHighlightSimpleSurface.js
index c4277b3..a40cafa 100644
--- a/modules/syntaxhighlight/ve.ui.MWSyntaxHighlightSimpleSurface.js
+++ b/modules/syntaxhighlight/ve.ui.MWSyntaxHighlightSimpleSurface.js
@@ -126,6 +126,7 @@
);
this.$editboxLayer
.addClass( 've-ui-simplesurface-container-editbox' )
+   .addClass( 'oo-ui-ltr' )
.append( this.$lineNumberLayer
.addClass( 
've-ui-simplesurface-container-editbox-lineNumber' )
.append( this.$lineNumber

-- 
To view, visit https://gerrit.wikimedia.org/r/94424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iae7f9eee20ffb9a003830503865458918f5e1df3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo mor...@gmail.com
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits