[MediaWiki-commits] [Gerrit] Formatters for JSON? - change (mediawiki...Wikibase)

2014-12-03 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Formatters for JSON?
..


Formatters for JSON?

A Formatter that outputs JSON is not a Formatter, that's a
Serializer.

Change-Id: Ib91de650f86f65fbb392d30df223b98ca64b59cc
---
M lib/includes/formatters/SnakFormatter.php
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Daniel Kinzler: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/includes/formatters/SnakFormatter.php 
b/lib/includes/formatters/SnakFormatter.php
index a0d9578..570abe8 100644
--- a/lib/includes/formatters/SnakFormatter.php
+++ b/lib/includes/formatters/SnakFormatter.php
@@ -25,7 +25,6 @@
const FORMAT_HTML = 'text/html';
const FORMAT_HTML_WIDGET = 'text/html; disposition=widget';
const FORMAT_HTML_DIFF = 'text/html; disposition=diff';
-   const FORMAT_JSON = 'application/json';
 
/**
 * Formats a snak.

-- 
To view, visit https://gerrit.wikimedia.org/r/177258
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib91de650f86f65fbb392d30df223b98ca64b59cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Formatters for JSON? - change (mediawiki...Wikibase)

2014-12-03 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/177258

Change subject: Formatters for JSON?
..

Formatters for JSON?

A Formatter that outputs JSON is not a Formatter, that's a
Serializer.

Change-Id: Ib91de650f86f65fbb392d30df223b98ca64b59cc
---
M lib/includes/formatters/SnakFormatter.php
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/58/177258/1

diff --git a/lib/includes/formatters/SnakFormatter.php 
b/lib/includes/formatters/SnakFormatter.php
index a0d9578..570abe8 100644
--- a/lib/includes/formatters/SnakFormatter.php
+++ b/lib/includes/formatters/SnakFormatter.php
@@ -25,7 +25,6 @@
const FORMAT_HTML = 'text/html';
const FORMAT_HTML_WIDGET = 'text/html; disposition=widget';
const FORMAT_HTML_DIFF = 'text/html; disposition=diff';
-   const FORMAT_JSON = 'application/json';
 
/**
 * Formats a snak.

-- 
To view, visit https://gerrit.wikimedia.org/r/177258
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib91de650f86f65fbb392d30df223b98ca64b59cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits