[MediaWiki-commits] [Gerrit] Get rid of term "handle" in the context of properties in bro... - change (mediawiki...Wikibase)
jenkins-bot has submitted this change and it was merged. Change subject: Get rid of term "handle" in the context of properties in browsertest features .. Get rid of term "handle" in the context of properties in browsertest features Change-Id: I63203649f2c631f02790c58ca3aa8a57c16e204f --- M tests/browser/features/statement.feature M tests/browser/features/statements_item.feature M tests/browser/features/statements_string.feature M tests/browser/features/step_definitions/entity_steps.rb 4 files changed, 9 insertions(+), 9 deletions(-) Approvals: Thiemo Mättig (WMDE): Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/statement.feature b/tests/browser/features/statement.feature index 02d66c3..a3a85eb 100644 --- a/tests/browser/features/statement.feature +++ b/tests/browser/features/statement.feature @@ -48,7 +48,7 @@ @ui_only @repo_login Scenario: Select a property -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop @@ -60,7 +60,7 @@ @ui_only @repo_login @smoke Scenario: Select a property and enter a statement value -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop @@ -73,7 +73,7 @@ @ui_only @repo_login Scenario Outline: Cancel statement after selecting a property -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop @@ -93,7 +93,7 @@ @ui_only @repo_login Scenario: Select a property, enter a statement value and clear the property -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop diff --git a/tests/browser/features/statements_item.feature b/tests/browser/features/statements_item.feature index d250219..6e56900 100644 --- a/tests/browser/features/statements_item.feature +++ b/tests/browser/features/statements_item.feature @@ -15,7 +15,7 @@ @repo_login @modify_entity Scenario Outline: Adding a statement of type item -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | itemprop | wikibase-item | Given I have the following items: | item1 | diff --git a/tests/browser/features/statements_string.feature b/tests/browser/features/statements_string.feature index 9e7403e..115754f 100644 --- a/tests/browser/features/statements_string.feature +++ b/tests/browser/features/statements_string.feature @@ -15,7 +15,7 @@ @repo_login @modify_entity Scenario Outline: Adding a statement of type string -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop @@ -37,7 +37,7 @@ @repo_login @modify_entity Scenario: Adding a statement of type string and reload page -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop @@ -55,7 +55,7 @@ @repo_login @modify_entity Scenario: Adding a statement of type string with a too long string -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop diff --git a/tests/browser/features/step_definitions/entity_steps.rb b/tests/browser/features/step_definitions/entity_steps.rb index 9d70d7d..b06cdfe 100644 --- a/tests/browser/features/step_definitions/entity_steps.rb +++ b/tests/browser/features/step_definitions/entity_steps.rb @@ -45,7 +45,7 @@ on(ItemPage).navigate_to_entity @items[item_handle]["url"] end -Given /^There are properties with the following handles and datatypes:$/ do |props| +Given /^I have the following properties with datatype:$/ do |props| wb_api = WikibaseAPI::Gateway.new(URL.repo_api) wb_api.login(ENV["WB_REPO_USERNAME"], ENV["WB_REPO_PASSWORD"]) @properties = wb_api.wb_create_properties(props.raw) -- To view, visit https://gerrit.wikimedia.o
[MediaWiki-commits] [Gerrit] Get rid of term "handle" in the context of properties in bro... - change (mediawiki...Wikibase)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/123851 Change subject: Get rid of term "handle" in the context of properties in browsertest features .. Get rid of term "handle" in the context of properties in browsertest features Change-Id: I63203649f2c631f02790c58ca3aa8a57c16e204f --- M tests/browser/features/statement.feature M tests/browser/features/statements_item.feature M tests/browser/features/statements_string.feature M tests/browser/features/step_definitions/entity_steps.rb 4 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/51/123851/1 diff --git a/tests/browser/features/statement.feature b/tests/browser/features/statement.feature index 02d66c3..a3a85eb 100644 --- a/tests/browser/features/statement.feature +++ b/tests/browser/features/statement.feature @@ -48,7 +48,7 @@ @ui_only @repo_login Scenario: Select a property -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop @@ -60,7 +60,7 @@ @ui_only @repo_login @smoke Scenario: Select a property and enter a statement value -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop @@ -73,7 +73,7 @@ @ui_only @repo_login Scenario Outline: Cancel statement after selecting a property -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop @@ -93,7 +93,7 @@ @ui_only @repo_login Scenario: Select a property, enter a statement value and clear the property -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop diff --git a/tests/browser/features/statements_item.feature b/tests/browser/features/statements_item.feature index d250219..6e56900 100644 --- a/tests/browser/features/statements_item.feature +++ b/tests/browser/features/statements_item.feature @@ -15,7 +15,7 @@ @repo_login @modify_entity Scenario Outline: Adding a statement of type item -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | itemprop | wikibase-item | Given I have the following items: | item1 | diff --git a/tests/browser/features/statements_string.feature b/tests/browser/features/statements_string.feature index 9e7403e..115754f 100644 --- a/tests/browser/features/statements_string.feature +++ b/tests/browser/features/statements_string.feature @@ -15,7 +15,7 @@ @repo_login @modify_entity Scenario Outline: Adding a statement of type string -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop @@ -37,7 +37,7 @@ @repo_login @modify_entity Scenario: Adding a statement of type string and reload page -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop @@ -55,7 +55,7 @@ @repo_login @modify_entity Scenario: Adding a statement of type string with a too long string -Given There are properties with the following handles and datatypes: +Given I have the following properties with datatype: | stringprop | string | When I click the statement add button And I select the property stringprop diff --git a/tests/browser/features/step_definitions/entity_steps.rb b/tests/browser/features/step_definitions/entity_steps.rb index e110e6f..29ab6f4 100644 --- a/tests/browser/features/step_definitions/entity_steps.rb +++ b/tests/browser/features/step_definitions/entity_steps.rb @@ -41,7 +41,7 @@ on(ItemPage).navigate_to_entity @item_under_test["url"] end -Given /^There are properties with the following handles and datatypes:$/ do |props| +Given /^I have the following properties with datatype:$/ do |props| wb_api = WikibaseAPI::Gateway.new(URL.repo_api) wb_api.login(ENV["WB_REPO_USERNAME"], ENV["WB_REPO_PASSWORD"]) @properties = wb_api.wb_create_properties(props.