[MediaWiki-commits] [Gerrit] Hide 'no results found' once there's at least one result - change (mediawiki...VisualEditor)

2014-05-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Hide 'no results found' once there's at least one result
..


Hide 'no results found' once there's at least one result

Naturally, the 'no results found' should only appear as long as there
are actually no results found. 

Bug: 52463
Change-Id: I0116b769b9e4995678975d43a74c54c4d426f672
(cherry picked from commit 3a9faa44fcc7bbf08eba1fd2c4b70a2c9c3c5770)
---
M modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js 
b/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
index 24b6ed9..7d2147d 100755
--- a/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
@@ -181,6 +181,12 @@
this.$noItemsMessage.show();
}
}
+
+   // Even if the whole list of sources didn't finish yet
+   // if there are results, make the message go away
+   if ( this.results.getItems().length  0 ) {
+   this.$noItemsMessage.hide();
+   }
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/133864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0116b769b9e4995678975d43a74c54c4d426f672
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.24wmf5
Gerrit-Owner: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: Mooeypoo mor...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hide 'no results found' once there's at least one result - change (mediawiki...VisualEditor)

2014-05-16 Thread Mooeypoo (Code Review) 
Mooeypoo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/133858

Change subject: Hide 'no results found' once there's at least one result
..

Hide 'no results found' once there's at least one result

Naturally, the 'no results found' should only appear as long as there
are actually no results found.

Bug: 52463
Change-Id: I0116b769b9e4995678975d43a74c54c4d426f672
---
M modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/58/133858/1

diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js 
b/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
index 24b6ed9..7d2147d 100755
--- a/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
@@ -181,6 +181,12 @@
this.$noItemsMessage.show();
}
}
+
+   // Even if the whole list of sources didn't finish yet
+   // if there are results, make the message go away
+   if ( this.results.getItems().length  0 ) {
+   this.$noItemsMessage.hide();
+   }
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/133858
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0116b769b9e4995678975d43a74c54c4d426f672
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo mor...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hide 'no results found' once there's at least one result - change (mediawiki...VisualEditor)

2014-05-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Hide 'no results found' once there's at least one result
..


Hide 'no results found' once there's at least one result

Naturally, the 'no results found' should only appear as long as there
are actually no results found.

Bug: 52463
Change-Id: I0116b769b9e4995678975d43a74c54c4d426f672
---
M modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js 
b/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
index 24b6ed9..7d2147d 100755
--- a/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
@@ -181,6 +181,12 @@
this.$noItemsMessage.show();
}
}
+
+   // Even if the whole list of sources didn't finish yet
+   // if there are results, make the message go away
+   if ( this.results.getItems().length  0 ) {
+   this.$noItemsMessage.hide();
+   }
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/133858
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0116b769b9e4995678975d43a74c54c4d426f672
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo mor...@gmail.com
Gerrit-Reviewer: Catrope roan.katt...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hide 'no results found' once there's at least one result - change (mediawiki...VisualEditor)

2014-05-16 Thread Jforrester (Code Review) 
Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/133864

Change subject: Hide 'no results found' once there's at least one result
..

Hide 'no results found' once there's at least one result

Naturally, the 'no results found' should only appear as long as there
are actually no results found.

Bug: 52463
Change-Id: I0116b769b9e4995678975d43a74c54c4d426f672
(cherry picked from commit 3a9faa44fcc7bbf08eba1fd2c4b70a2c9c3c5770)
---
M modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/64/133864/1

diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js 
b/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
index 24b6ed9..7d2147d 100755
--- a/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js
@@ -181,6 +181,12 @@
this.$noItemsMessage.show();
}
}
+
+   // Even if the whole list of sources didn't finish yet
+   // if there are results, make the message go away
+   if ( this.results.getItems().length  0 ) {
+   this.$noItemsMessage.hide();
+   }
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/133864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0116b769b9e4995678975d43a74c54c4d426f672
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.24wmf5
Gerrit-Owner: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: Mooeypoo mor...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits