[MediaWiki-commits] [Gerrit] Hide reference dialog when on-wiki link is clicked. - change (apps...wikipedia)

2014-07-25 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Hide reference dialog when on-wiki link is clicked.
..


Hide reference dialog when on-wiki link is clicked.

Bug: 68337
Change-Id: I44e6828adf65f2dc2ceb7ceeb577e09851df4822
---
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java 
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
index 8193eca..dc35700 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
@@ -326,6 +326,9 @@
 linkHandler = new LinkHandler(getActivity(), bridge, title.getSite()) {
 @Override
 public void onInternalLinkClicked(PageTitle title) {
+if (referenceDialog != null  referenceDialog.isShowing()) {
+referenceDialog.dismiss();
+}
 HistoryEntry historyEntry = new HistoryEntry(title, 
HistoryEntry.SOURCE_INTERNAL_LINK);
 app.getBus().post(new NewWikiPageNavigationEvent(title, 
historyEntry));
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/149006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44e6828adf65f2dc2ceb7ceeb577e09851df4822
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant dbr...@wikimedia.org
Gerrit-Reviewer: BearND bsitzm...@wikimedia.org
Gerrit-Reviewer: Brion VIBBER br...@wikimedia.org
Gerrit-Reviewer: Yuvipanda yuvipa...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hide reference dialog when on-wiki link is clicked. - change (apps...wikipedia)

2014-07-24 Thread Dbrant (Code Review) 
Dbrant has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/149006

Change subject: Hide reference dialog when on-wiki link is clicked.
..

Hide reference dialog when on-wiki link is clicked.

Bug: 68337
Change-Id: I44e6828adf65f2dc2ceb7ceeb577e09851df4822
---
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/06/149006/1

diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java 
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
index 8193eca..dc35700 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
@@ -326,6 +326,9 @@
 linkHandler = new LinkHandler(getActivity(), bridge, title.getSite()) {
 @Override
 public void onInternalLinkClicked(PageTitle title) {
+if (referenceDialog != null  referenceDialog.isShowing()) {
+referenceDialog.dismiss();
+}
 HistoryEntry historyEntry = new HistoryEntry(title, 
HistoryEntry.SOURCE_INTERNAL_LINK);
 app.getBus().post(new NewWikiPageNavigationEvent(title, 
historyEntry));
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/149006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I44e6828adf65f2dc2ceb7ceeb577e09851df4822
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant dbr...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits