[MediaWiki-commits] [Gerrit] Hygiene: Fancy string generation on collection tests - change (mediawiki...Gather)

2015-04-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Hygiene: Fancy string generation on collection tests
..


Hygiene: Fancy string generation on collection tests

Change-Id: I37e4e6f532505645a263dd93da1e0b54bd892e56
---
M tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
1 file changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js 
b/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
index f66d614..86d1cfd 100644
--- a/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
+++ b/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
@@ -24,14 +24,10 @@
/**
 * Generate string of a certain length
 * @param {Number} length length of desired string
-* @returns {String} randomly generated string
+* @returns {String} generated string
 */
function getStringWithLength( len ) {
-   var i, str = '';
-   for ( i = 0; i  len; i++ ) {
-   str += 'a';
-   }
-   return str;
+   return Array( len + 1 ).join( 'a' );
}
 
QUnit.test( 'Collection title validation', 2, function ( assert ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/202606
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I37e4e6f532505645a263dd93da1e0b54bd892e56
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Robmoen rm...@wikimedia.org
Gerrit-Reviewer: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hygiene: Fancy string generation on collection tests - change (mediawiki...Gather)

2015-04-07 Thread Robmoen (Code Review) 
Robmoen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/202606

Change subject: Hygiene: Fancy string generation on collection tests
..

Hygiene: Fancy string generation on collection tests

Change-Id: I37e4e6f532505645a263dd93da1e0b54bd892e56
---
M tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather 
refs/changes/06/202606/1

diff --git 
a/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js 
b/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
index f66d614..86d1cfd 100644
--- a/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
+++ b/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js
@@ -24,14 +24,10 @@
/**
 * Generate string of a certain length
 * @param {Number} length length of desired string
-* @returns {String} randomly generated string
+* @returns {String} generated string
 */
function getStringWithLength( len ) {
-   var i, str = '';
-   for ( i = 0; i  len; i++ ) {
-   str += 'a';
-   }
-   return str;
+   return Array( len + 1 ).join( 'a' );
}
 
QUnit.test( 'Collection title validation', 2, function ( assert ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/202606
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I37e4e6f532505645a263dd93da1e0b54bd892e56
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Robmoen rm...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits