[MediaWiki-commits] [Gerrit] Hygiene: Remove empty anchor tag - change (mediawiki...Gather)

2015-04-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Hygiene: Remove empty anchor tag
..


Hygiene: Remove empty anchor tag

Change-Id: Id2b8016c83101f7f3d05b423ecbf39a16268b9c4
---
M includes/views/CollectionItemCard.php
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Jhernandez: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/views/CollectionItemCard.php 
b/includes/views/CollectionItemCard.php
index 303f7cd..9966389 100644
--- a/includes/views/CollectionItemCard.php
+++ b/includes/views/CollectionItemCard.php
@@ -47,10 +47,14 @@
protected function getHtml() {
$item = $this-item;
$title = $item-getTitle();
+   $img = $this-image-getHtml();
+   if ( $img ) {
+   $img = Html::openElement( 'a', array( 'href' = 
$title-getLocalUrl() ) ) .
+   $img .
+   Html::closeElement( 'a' );
+   }
$html = Html::openElement( 'div', array( 'class' = 
'collection-item' ) ) .
-   Html::openElement( 'a', array( 'href' = 
$title-getLocalUrl() ) ) .
-   $this-image-getHtml() .
-   Html::closeElement( 'a' ) .
+   $img .
Html::openElement( 'h2', array( 'class' = 
'collection-item-title' ) ) .
Linker::link( $title ) .
Html::closeElement( 'h2' );

-- 
To view, visit https://gerrit.wikimedia.org/r/201589
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2b8016c83101f7f3d05b423ecbf39a16268b9c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: Jhernandez jhernan...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hygiene: Remove empty anchor tag - change (mediawiki...Gather)

2015-04-02 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/201589

Change subject: Hygiene: Remove empty anchor tag
..

Hygiene: Remove empty anchor tag

Change-Id: Id2b8016c83101f7f3d05b423ecbf39a16268b9c4
---
M includes/views/CollectionItemCard.php
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather 
refs/changes/89/201589/1

diff --git a/includes/views/CollectionItemCard.php 
b/includes/views/CollectionItemCard.php
index 303f7cd..9966389 100644
--- a/includes/views/CollectionItemCard.php
+++ b/includes/views/CollectionItemCard.php
@@ -47,10 +47,14 @@
protected function getHtml() {
$item = $this-item;
$title = $item-getTitle();
+   $img = $this-image-getHtml();
+   if ( $img ) {
+   $img = Html::openElement( 'a', array( 'href' = 
$title-getLocalUrl() ) ) .
+   $img .
+   Html::closeElement( 'a' );
+   }
$html = Html::openElement( 'div', array( 'class' = 
'collection-item' ) ) .
-   Html::openElement( 'a', array( 'href' = 
$title-getLocalUrl() ) ) .
-   $this-image-getHtml() .
-   Html::closeElement( 'a' ) .
+   $img .
Html::openElement( 'h2', array( 'class' = 
'collection-item-title' ) ) .
Linker::link( $title ) .
Html::closeElement( 'h2' );

-- 
To view, visit https://gerrit.wikimedia.org/r/201589
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2b8016c83101f7f3d05b423ecbf39a16268b9c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson jrob...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits