[MediaWiki-commits] [Gerrit] Hygiene: Remove need in QA tests for LogoutPage - change (mediawiki...MobileFrontend)

2014-03-04 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Hygiene: Remove need in QA tests for LogoutPage
..


Hygiene: Remove need in QA tests for LogoutPage

Change-Id: Ic2ec862d6498ff375fd3fe8ddee1cc9b9e42b7ec
---
M tests/browser/features/step_definitions/common_steps.rb
D tests/browser/features/support/pages/logout_page.rb
2 files changed, 1 insertion(+), 6 deletions(-)

Approvals:
  JGonera: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/browser/features/step_definitions/common_steps.rb 
b/tests/browser/features/step_definitions/common_steps.rb
index 8acbf0b..d42634a 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -30,7 +30,7 @@
 page.password_field_element.when_present.send_keys(pwd)
 page.confirm_password_field_element.when_present.send_keys(pwd)
 page.sign_up_element.when_present.click
-visit(LogoutPage)
+step 'I go to the "Special:UserLogout" page'
 visit(LoginPage) do |page|
   page.login_with(username, pwd)
 end
diff --git a/tests/browser/features/support/pages/logout_page.rb 
b/tests/browser/features/support/pages/logout_page.rb
deleted file mode 100644
index 9183ca0..000
--- a/tests/browser/features/support/pages/logout_page.rb
+++ /dev/null
@@ -1,5 +0,0 @@
-class LogoutPage
-  include PageObject
-  include URL
-  page_url URL.url("Special:UserLogout")
-end

-- 
To view, visit https://gerrit.wikimedia.org/r/116696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2ec862d6498ff375fd3fe8ddee1cc9b9e42b7ec
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: JGonera 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hygiene: Remove need in QA tests for LogoutPage - change (mediawiki...MobileFrontend)

2014-03-03 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/116696

Change subject: Hygiene: Remove need in QA tests for LogoutPage
..

Hygiene: Remove need in QA tests for LogoutPage

Change-Id: Ic2ec862d6498ff375fd3fe8ddee1cc9b9e42b7ec
---
M tests/browser/features/step_definitions/common_steps.rb
D tests/browser/features/support/pages/logout_page.rb
2 files changed, 1 insertion(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/96/116696/1

diff --git a/tests/browser/features/step_definitions/common_steps.rb 
b/tests/browser/features/step_definitions/common_steps.rb
index 8acbf0b..d42634a 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -30,7 +30,7 @@
 page.password_field_element.when_present.send_keys(pwd)
 page.confirm_password_field_element.when_present.send_keys(pwd)
 page.sign_up_element.when_present.click
-visit(LogoutPage)
+step 'I go to the "Special:UserLogout" page'
 visit(LoginPage) do |page|
   page.login_with(username, pwd)
 end
diff --git a/tests/browser/features/support/pages/logout_page.rb 
b/tests/browser/features/support/pages/logout_page.rb
deleted file mode 100644
index 9183ca0..000
--- a/tests/browser/features/support/pages/logout_page.rb
+++ /dev/null
@@ -1,5 +0,0 @@
-class LogoutPage
-  include PageObject
-  include URL
-  page_url URL.url("Special:UserLogout")
-end

-- 
To view, visit https://gerrit.wikimedia.org/r/116696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2ec862d6498ff375fd3fe8ddee1cc9b9e42b7ec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits