[MediaWiki-commits] [Gerrit] Hygiene: Remove redundant returns - change (mediawiki...MobileFrontend)

2014-12-22 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Hygiene: Remove redundant returns
..


Hygiene: Remove redundant returns

Change-Id: I9c8fd16e5ddd8bf62b1c2ef931b70f41d116cd41
---
M .jscsrc
M javascripts/modules/editor/EditorApi.js
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jhernandez: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.jscsrc b/.jscsrc
index c202df7..0ae6855 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -20,6 +20,7 @@
   ],
   jsDoc: {
 enforceExistence: true,
-checkReturnTypes: true
+checkReturnTypes: true,
+checkRedundantReturns: true
   }
 }
diff --git a/javascripts/modules/editor/EditorApi.js 
b/javascripts/modules/editor/EditorApi.js
index 818f50c..3fb9231 100644
--- a/javascripts/modules/editor/EditorApi.js
+++ b/javascripts/modules/editor/EditorApi.js
@@ -118,7 +118,6 @@
/**
 * Save content. Make an API request.
 * @ignore
-* @returns {jquery.Deferred}
 */
function saveContent() {
var apiOptions = {

-- 
To view, visit https://gerrit.wikimedia.org/r/181099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9c8fd16e5ddd8bf62b1c2ef931b70f41d116cd41
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson jrob...@wikimedia.org
Gerrit-Reviewer: Bmansurov bmansu...@wikimedia.org
Gerrit-Reviewer: Jhernandez jhernan...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Hygiene: Remove redundant returns - change (mediawiki...MobileFrontend)

2014-12-19 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/181099

Change subject: Hygiene: Remove redundant returns
..

Hygiene: Remove redundant returns

Change-Id: I9c8fd16e5ddd8bf62b1c2ef931b70f41d116cd41
---
M .jscsrc
M javascripts/modules/editor/EditorApi.js
2 files changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/99/181099/1

diff --git a/.jscsrc b/.jscsrc
index 46a09a1..0ae6855 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -21,5 +21,6 @@
   jsDoc: {
 enforceExistence: true,
 checkReturnTypes: true,
+checkRedundantReturns: true
   }
 }
diff --git a/javascripts/modules/editor/EditorApi.js 
b/javascripts/modules/editor/EditorApi.js
index 818f50c..3fb9231 100644
--- a/javascripts/modules/editor/EditorApi.js
+++ b/javascripts/modules/editor/EditorApi.js
@@ -118,7 +118,6 @@
/**
 * Save content. Make an API request.
 * @ignore
-* @returns {jquery.Deferred}
 */
function saveContent() {
var apiOptions = {

-- 
To view, visit https://gerrit.wikimedia.org/r/181099
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c8fd16e5ddd8bf62b1c2ef931b70f41d116cd41
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson jrob...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits