[MediaWiki-commits] [Gerrit] Hygiene: Use a better name for a foreach variable - change (mediawiki...QuickSearchLookup)
Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/231977 Change subject: Hygiene: Use a better name for a foreach variable .. Hygiene: Use a better name for a foreach variable Follow up: I7aca81842e627af Change-Id: I8ea7c7536abc2968c448f7af4818077b8c9e0af9 --- M includes/QuickSearchLookup.php 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuickSearchLookup refs/changes/77/231977/1 diff --git a/includes/QuickSearchLookup.php b/includes/QuickSearchLookup.php index b1e78b6..060e161 100644 --- a/includes/QuickSearchLookup.php +++ b/includes/QuickSearchLookup.php @@ -287,9 +287,9 @@ $api = new ApiMain( $params ); $api->execute(); $data = $api->getResult()->getResultData(); - foreach ( $data['query']['pages'] as $id => $d ) { - if ( isset( $d['pageid'] ) ) { - $this->metadata = $d; + foreach ( $data['query']['pages'] as $id => $page ) { + if ( isset( $page['pageid'] ) ) { + $this->metadata = $page; } } } @@ -376,4 +376,4 @@ } return $res; } -} \ No newline at end of file +} -- To view, visit https://gerrit.wikimedia.org/r/231977 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8ea7c7536abc2968c448f7af4818077b8c9e0af9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/QuickSearchLookup Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Hygiene: Use a better name for a foreach variable - change (mediawiki...QuickSearchLookup)
jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: Use a better name for a foreach variable .. Hygiene: Use a better name for a foreach variable Follow up: I7aca81842e627af Change-Id: I8ea7c7536abc2968c448f7af4818077b8c9e0af9 --- M includes/QuickSearchLookup.php 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Florianschmidtwelzow: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/QuickSearchLookup.php b/includes/QuickSearchLookup.php index b1e78b6..060e161 100644 --- a/includes/QuickSearchLookup.php +++ b/includes/QuickSearchLookup.php @@ -287,9 +287,9 @@ $api = new ApiMain( $params ); $api->execute(); $data = $api->getResult()->getResultData(); - foreach ( $data['query']['pages'] as $id => $d ) { - if ( isset( $d['pageid'] ) ) { - $this->metadata = $d; + foreach ( $data['query']['pages'] as $id => $page ) { + if ( isset( $page['pageid'] ) ) { + $this->metadata = $page; } } } @@ -376,4 +376,4 @@ } return $res; } -} \ No newline at end of file +} -- To view, visit https://gerrit.wikimedia.org/r/231977 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ea7c7536abc2968c448f7af4818077b8c9e0af9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/QuickSearchLookup Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow Gerrit-Reviewer: Florianschmidtwelzow Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits