[MediaWiki-commits] [Gerrit] Improve handling of the required argument in HTMLForm field ... - change (mediawiki/core[master])

2012-08-12 Thread IAlex (Code Review) 
IAlex has submitted this change and it was merged.

Change subject: Improve handling of the required argument in HTMLForm field 
definitions
..


Improve handling of the required argument in HTMLForm field definitions

array( 'required' => false ) will now result in the field not being required 
rather then the unexpected opossite.

And this is now possible (without doing some extra if)

array( 'required' => getSomeBoolean() )

Change-Id: I1fc22b16ab1fa17111c48aa664aaf47de5f7075a
---
M includes/HTMLForm.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  IAlex: Looks good to me, approved
  Platonides: Looks good to me, but someone else must approve
  jenkins-bot: Verified


--
To view, visit https://gerrit.wikimedia.org/r/18986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1fc22b16ab1fa17111c48aa664aaf47de5f7075a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Daniel Werner 
Gerrit-Reviewer: IAlex 
Gerrit-Reviewer: Jeroen De Dauw 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Platonides 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Improve handling of the required argument in HTMLForm field ... - change (mediawiki/core[master])

2012-08-11 Thread Jeroen De Dauw (Code Review) 
Jeroen De Dauw has uploaded a new change for review.

Change subject: Improve handling of the required argument in HTMLForm field 
definitions
..

Improve handling of the required argument in HTMLForm field definitions

array( 'required' => false ) will now result in the field not being required 
rather then the unexpected opossite.

And this is now possible (without doing some extra if)

array( 'required' => getSomeBoolean() )

Change-Id: I1fc22b16ab1fa17111c48aa664aaf47de5f7075a
---
M includes/HTMLForm.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/86/18986/1
--
To view, visit https://gerrit.wikimedia.org/r/18986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fc22b16ab1fa17111c48aa664aaf47de5f7075a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits