[MediaWiki-commits] [Gerrit] Improved handling when "more results text" is set to blank - change (mediawiki...Cargo)

2015-07-27 Thread Yaron Koren (Code Review) 
Yaron Koren has submitted this change and it was merged.

Change subject: Improved handling when "more results text" is set to blank
..


Improved handling when "more results text" is set to blank

Change-Id: I5e50a86fd5965d43395f84ed76e48df1745ac059
---
M CargoQueryDisplayer.php
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Yaron Koren: Checked; Looks good to me, approved



diff --git a/CargoQueryDisplayer.php b/CargoQueryDisplayer.php
index c7544fc..df9aef6 100644
--- a/CargoQueryDisplayer.php
+++ b/CargoQueryDisplayer.php
@@ -247,8 +247,11 @@
$vd = Title::makeTitleSafe( NS_SPECIAL, 'ViewData' );
if ( array_key_exists( 'more results text', 
$this->mDisplayParams ) ) {
$moreResultsText = $this->mDisplayParams['more results 
text'];
-   }
-   else {
+   // If the value is blank, don't show a link at all.
+   if ( $moreResultsText == '' ) {
+   return '';
+   }
+   } else {
$moreResultsText = wfMessage( 'moredotdotdot' 
)->parse();
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/227228
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e50a86fd5965d43395f84ed76e48df1745ac059
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Improved handling when "more results text" is set to blank - change (mediawiki...Cargo)

2015-07-27 Thread Yaron Koren (Code Review) 
Yaron Koren has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/227228

Change subject: Improved handling when "more results text" is set to blank
..

Improved handling when "more results text" is set to blank

Change-Id: I5e50a86fd5965d43395f84ed76e48df1745ac059
---
M CargoQueryDisplayer.php
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/28/227228/1

diff --git a/CargoQueryDisplayer.php b/CargoQueryDisplayer.php
index c7544fc..df9aef6 100644
--- a/CargoQueryDisplayer.php
+++ b/CargoQueryDisplayer.php
@@ -247,8 +247,11 @@
$vd = Title::makeTitleSafe( NS_SPECIAL, 'ViewData' );
if ( array_key_exists( 'more results text', 
$this->mDisplayParams ) ) {
$moreResultsText = $this->mDisplayParams['more results 
text'];
-   }
-   else {
+   // If the value is blank, don't show a link at all.
+   if ( $moreResultsText == '' ) {
+   return '';
+   }
+   } else {
$moreResultsText = wfMessage( 'moredotdotdot' 
)->parse();
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/227228
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e50a86fd5965d43395f84ed76e48df1745ac059
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits