[MediaWiki-commits] [Gerrit] Increase line-height for source and translation content to 1... - change (mediawiki...ContentTranslation)

2015-07-30 Thread Pginer (Code Review) 
Pginer has submitted this change and it was merged.

Change subject: Increase line-height for source and translation content to 1.5em
..


Increase line-height for source and translation content to 1.5em

Applying general typography guidelines for better readability.
Resulting font-size: 16px, line-height: 24px.

Paragraph margin also adjusted to 1.5em

Change-Id: Ia1bef3c54737102f872c87e69250d2276b104d54
---
M modules/translationview/styles/ext.cx.translationview.less
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Pginer: Looks good to me, approved



diff --git a/modules/translationview/styles/ext.cx.translationview.less 
b/modules/translationview/styles/ext.cx.translationview.less
index 8b8e823..9245d72 100644
--- a/modules/translationview/styles/ext.cx.translationview.less
+++ b/modules/translationview/styles/ext.cx.translationview.less
@@ -54,7 +54,7 @@
}
 
p {
-   margin-top: 1.2em;
+   margin: 1.5em 0;
}
 
.cx-column__sub-heading {
@@ -65,6 +65,7 @@
}
 
.cx-column__content {
+   line-height: 1.5em;
clear: both;
word-wrap: break-word;
position: relative;

-- 
To view, visit https://gerrit.wikimedia.org/r/227207
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1bef3c54737102f872c87e69250d2276b104d54
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com
Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il
Gerrit-Reviewer: Pginer pgi...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Increase line-height for source and translation content to 1... - change (mediawiki...ContentTranslation)

2015-07-27 Thread Santhosh (Code Review) 
Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/227207

Change subject: Increase line-height for source and translation content to 1.5em
..

Increase line-height for source and translation content to 1.5em

Applying general typography guidelines for better readability.
Resulting font-size: 16px, line-height: 24px.

Change-Id: Ia1bef3c54737102f872c87e69250d2276b104d54
---
M modules/translationview/styles/ext.cx.translationview.less
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/07/227207/1

diff --git a/modules/translationview/styles/ext.cx.translationview.less 
b/modules/translationview/styles/ext.cx.translationview.less
index 8b8e823..f897abf 100644
--- a/modules/translationview/styles/ext.cx.translationview.less
+++ b/modules/translationview/styles/ext.cx.translationview.less
@@ -65,6 +65,7 @@
}
 
.cx-column__content {
+   line-height: 1.5em;
clear: both;
word-wrap: break-word;
position: relative;

-- 
To view, visit https://gerrit.wikimedia.org/r/227207
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1bef3c54737102f872c87e69250d2276b104d54
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh santhosh.thottin...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits