[MediaWiki-commits] [Gerrit] Initial SavedPages eventlogging for iOS - change (apps...wikipedia)
Mhurd has submitted this change and it was merged.
Change subject: Initial SavedPages eventlogging for iOS
..
Initial SavedPages eventlogging for iOS
now with the actual classes
Change-Id: Iba7164704a950e53a60988f194787fa97b4415fd
---
M Wikipedia.xcodeproj/project.pbxproj
M wikipedia/Data/Operations/LogEventOp.h
M wikipedia/Data/Operations/LogEventOp.m
M wikipedia/EventLogging/EventLoggingFunnel.h
M wikipedia/EventLogging/EventLoggingFunnel.m
A wikipedia/EventLogging/SavedPagesFunnel.h
A wikipedia/EventLogging/SavedPagesFunnel.m
M wikipedia/Importer/ArticleImporter.m
M wikipedia/View Controllers/Preview/PreviewAndSaveViewController.h
M wikipedia/View Controllers/Preview/PreviewAndSaveViewController.m
M wikipedia/View Controllers/SavedPages/SavedPagesViewController.m
M wikipedia/View Controllers/SectionEditor/SectionEditorViewController.h
M wikipedia/View Controllers/SectionEditor/SectionEditorViewController.m
M wikipedia/View Controllers/WebView/WebViewController.m
14 files changed, 168 insertions(+), 7 deletions(-)
Approvals:
Mhurd: Verified; Looks good to me, approved
diff --git a/Wikipedia.xcodeproj/project.pbxproj
b/Wikipedia.xcodeproj/project.pbxproj
index fc9284e..ecebe49 100644
--- a/Wikipedia.xcodeproj/project.pbxproj
+++ b/Wikipedia.xcodeproj/project.pbxproj
@@ -179,6 +179,7 @@
D46CD8C518A1AC4F0042959E /* Localizable.strings in Resources */
= {isa = PBXBuildFile; fileRef = D46CD8C218A1AC4F0042959E /*
Localizable.strings */; };
D474CC15182AE196002BDE45 /* MWSite.m in Sources */ = {isa =
PBXBuildFile; fileRef = D474CC14182AE196002BDE45 /* MWSite.m */; };
D47FEE2019C8CBB998C8 /* Main_iPhone.strings in Resources */
= {isa = PBXBuildFile; fileRef = D47FEE1E19C8CBB998C8 /*
Main_iPhone.strings */; };
+ D47BF5D4197870390067C3BC /* SavedPagesFunnel.m in Sources */ =
{isa = PBXBuildFile; fileRef = D47BF5D3197870390067C3BC /* SavedPagesFunnel.m
*/; };
D4991439181D51DE00E6073C /* Foundation.framework in Frameworks
*/ = {isa = PBXBuildFile; fileRef = D4991438181D51DE00E6073C /*
Foundation.framework */; };
D499143B181D51DE00E6073C /* CoreGraphics.framework in
Frameworks */ = {isa = PBXBuildFile; fileRef = D499143A181D51DE00E6073C /*
CoreGraphics.framework */; };
D499143D181D51DE00E6073C /* UIKit.framework in Frameworks */ =
{isa = PBXBuildFile; fileRef = D499143C181D51DE00E6073C /* UIKit.framework */;
};
@@ -644,6 +645,8 @@
D47FEE2619C8CB6B00B998C8 /* cs */ = {isa = PBXFileReference;
lastKnownFileType = text.plist.strings; name = cs; path =
cs.lproj/Main_iPhone.strings; sourceTree = group; };
D47FEE2719C8CBB400B998C8 /* ta */ = {isa = PBXFileReference;
lastKnownFileType = text.plist.strings; name = ta; path =
ta.lproj/Main_iPhone.strings; sourceTree = group; };
D47FEE2819C8CC2600B998C8 /* pt-BR */ = {isa = PBXFileReference;
lastKnownFileType = text.plist.strings; name = pt-BR; path =
pt-BR.lproj/Localizable.strings; sourceTree = group; };
+ D47BF5D2197870390067C3BC /* SavedPagesFunnel.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
SavedPagesFunnel.h; path = EventLogging/SavedPagesFunnel.h; sourceTree =
group; };
+ D47BF5D3197870390067C3BC /* SavedPagesFunnel.m */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name
= SavedPagesFunnel.m; path = EventLogging/SavedPagesFunnel.m; sourceTree =
group; };
D4991435181D51DE00E6073C /* Wikipedia.app */ = {isa =
PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0;
path = Wikipedia.app; sourceTree = BUILT_PRODUCTS_DIR; };
D4991438181D51DE00E6073C /* Foundation.framework */ = {isa =
PBXFileReference; lastKnownFileType = wrapper.framework; name =
Foundation.framework; path = System/Library/Frameworks/Foundation.framework;
sourceTree = SDKROOT; };
D499143A181D51DE00E6073C /* CoreGraphics.framework */ = {isa =
PBXFileReference; lastKnownFileType = wrapper.framework; name =
CoreGraphics.framework; path =
System/Library/Frameworks/CoreGraphics.framework; sourceTree = SDKROOT; };
@@ -1632,6 +1635,8 @@
D4F277FA194235A00032BA38 /*
ProtectedEditAttemptFunnel.m */,
D4F277FC194235B50032BA38 /*
ToCInteractionFunnel.h */,
D4F277FD194235B50032BA38 /*
ToCInteractionFunnel.m */,
+ D47BF5D2197870390067C3BC /* SavedPagesFunnel.h
*/,
+ D47BF5D3197870390067C3BC /* SavedPagesFunnel.m
*/,
);
name = EventLogging;
sourceTree = group;
@@ -2060,6 +2065,7 @@
04C43A9D183440B0006C643B /*
[MediaWiki-commits] [Gerrit] Initial SavedPages eventlogging for iOS - change (apps...wikipedia)
Brion VIBBER has uploaded a new change for review.
https://gerrit.wikimedia.org/r/160496
Change subject: Initial SavedPages eventlogging for iOS
..
Initial SavedPages eventlogging for iOS
Change-Id: Iba7164704a950e53a60988f194787fa97b4415fd
---
M Wikipedia.xcodeproj/project.pbxproj
M wikipedia/Data/Operations/LogEventOp.h
M wikipedia/Data/Operations/LogEventOp.m
M wikipedia/EventLogging/EventLoggingFunnel.h
M wikipedia/EventLogging/EventLoggingFunnel.m
M wikipedia/Importer/ArticleImporter.m
M wikipedia/View Controllers/Preview/PreviewAndSaveViewController.h
M wikipedia/View Controllers/Preview/PreviewAndSaveViewController.m
M wikipedia/View Controllers/SavedPages/SavedPagesViewController.m
M wikipedia/View Controllers/SectionEditor/SectionEditorViewController.h
M wikipedia/View Controllers/SectionEditor/SectionEditorViewController.m
M wikipedia/View Controllers/WebView/WebViewController.m
12 files changed, 54 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/96/160496/1
diff --git a/Wikipedia.xcodeproj/project.pbxproj
b/Wikipedia.xcodeproj/project.pbxproj
index dc41b63..79b1da7 100644
--- a/Wikipedia.xcodeproj/project.pbxproj
+++ b/Wikipedia.xcodeproj/project.pbxproj
@@ -178,6 +178,7 @@
D46CD8C418A1AC4F0042959E /* InfoPlist.strings in Resources */ =
{isa = PBXBuildFile; fileRef = D46CD8C018A1AC4F0042959E /* InfoPlist.strings
*/; };
D46CD8C518A1AC4F0042959E /* Localizable.strings in Resources */
= {isa = PBXBuildFile; fileRef = D46CD8C218A1AC4F0042959E /*
Localizable.strings */; };
D474CC15182AE196002BDE45 /* MWSite.m in Sources */ = {isa =
PBXBuildFile; fileRef = D474CC14182AE196002BDE45 /* MWSite.m */; };
+ D47BF5D4197870390067C3BC /* SavedPagesFunnel.m in Sources */ =
{isa = PBXBuildFile; fileRef = D47BF5D3197870390067C3BC /* SavedPagesFunnel.m
*/; };
D4991439181D51DE00E6073C /* Foundation.framework in Frameworks
*/ = {isa = PBXBuildFile; fileRef = D4991438181D51DE00E6073C /*
Foundation.framework */; };
D499143B181D51DE00E6073C /* CoreGraphics.framework in
Frameworks */ = {isa = PBXBuildFile; fileRef = D499143A181D51DE00E6073C /*
CoreGraphics.framework */; };
D499143D181D51DE00E6073C /* UIKit.framework in Frameworks */ =
{isa = PBXBuildFile; fileRef = D499143C181D51DE00E6073C /* UIKit.framework */;
};
@@ -634,6 +635,8 @@
D474CC12182AE07C002BDE45 /* WikipediaApp.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
WikipediaApp.h; sourceTree = group; };
D474CC13182AE196002BDE45 /* MWSite.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
MWSite.h; path = mw-support/MWSite.h; sourceTree = group; };
D474CC14182AE196002BDE45 /* MWSite.m */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name
= MWSite.m; path = mw-support/MWSite.m; sourceTree = group; };
+ D47BF5D2197870390067C3BC /* SavedPagesFunnel.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
SavedPagesFunnel.h; path = EventLogging/SavedPagesFunnel.h; sourceTree =
group; };
+ D47BF5D3197870390067C3BC /* SavedPagesFunnel.m */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name
= SavedPagesFunnel.m; path = EventLogging/SavedPagesFunnel.m; sourceTree =
group; };
D4991435181D51DE00E6073C /* Wikipedia.app */ = {isa =
PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0;
path = Wikipedia.app; sourceTree = BUILT_PRODUCTS_DIR; };
D4991438181D51DE00E6073C /* Foundation.framework */ = {isa =
PBXFileReference; lastKnownFileType = wrapper.framework; name =
Foundation.framework; path = System/Library/Frameworks/Foundation.framework;
sourceTree = SDKROOT; };
D499143A181D51DE00E6073C /* CoreGraphics.framework */ = {isa =
PBXFileReference; lastKnownFileType = wrapper.framework; name =
CoreGraphics.framework; path =
System/Library/Frameworks/CoreGraphics.framework; sourceTree = SDKROOT; };
@@ -1621,6 +1624,8 @@
D4F277FA194235A00032BA38 /*
ProtectedEditAttemptFunnel.m */,
D4F277FC194235B50032BA38 /*
ToCInteractionFunnel.h */,
D4F277FD194235B50032BA38 /*
ToCInteractionFunnel.m */,
+ D47BF5D2197870390067C3BC /* SavedPagesFunnel.h
*/,
+ D47BF5D3197870390067C3BC /* SavedPagesFunnel.m
*/,
);
name = EventLogging;
sourceTree = group;
@@ -2045,6 +2050,7 @@
04C43A9D183440B0006C643B /* MWCrumbyTest.m in
