[MediaWiki-commits] [Gerrit] Interstitial should be fixed position - change (mediawiki...ZeroBanner)

2015-09-25 Thread Jhobs (Code Review) 
Jhobs has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/241104

Change subject: Interstitial should be fixed position
..

Interstitial should be fixed position

Fix interstitial styling to be fixed position relative
to the viewport. Solves height issue as well.

Change-Id: Ibe18abd4e7ee19e9f0ed07440503bbf3b3627fa0
---
M modules/interstitial.less
1 file changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroBanner 
refs/changes/04/241104/1

diff --git a/modules/interstitial.less b/modules/interstitial.less
index da04562..ff5131f 100644
--- a/modules/interstitial.less
+++ b/modules/interstitial.less
@@ -21,14 +21,12 @@
 /* end mixins */
 
 .zero-interstitial {
+   position: fixed;
padding: 25px 0;
-   max-width: 70%;
+   width: 70%;
max-height: 70%;
-   left: 15%;
-   right: 15%;
-   top: 15%;
-   bottom: 15%;
-   margin: auto;
+   min-height: 400px;
+   margin: 15%;
border: 1px solid #AAA;
.drop-shadow(@y: 4px);
.border-radius(25px);

-- 
To view, visit https://gerrit.wikimedia.org/r/241104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe18abd4e7ee19e9f0ed07440503bbf3b3627fa0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroBanner
Gerrit-Branch: master
Gerrit-Owner: Jhobs 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Interstitial should be fixed position - change (mediawiki...ZeroBanner)

2015-09-25 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Interstitial should be fixed position
..


Interstitial should be fixed position

Fix interstitial styling to be fixed position relative
to the viewport. Solves height issue as well.

Change-Id: Ibe18abd4e7ee19e9f0ed07440503bbf3b3627fa0
---
M modules/interstitial.less
1 file changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Yurik: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/interstitial.less b/modules/interstitial.less
index da04562..ff5131f 100644
--- a/modules/interstitial.less
+++ b/modules/interstitial.less
@@ -21,14 +21,12 @@
 /* end mixins */
 
 .zero-interstitial {
+   position: fixed;
padding: 25px 0;
-   max-width: 70%;
+   width: 70%;
max-height: 70%;
-   left: 15%;
-   right: 15%;
-   top: 15%;
-   bottom: 15%;
-   margin: auto;
+   min-height: 400px;
+   margin: 15%;
border: 1px solid #AAA;
.drop-shadow(@y: 4px);
.border-radius(25px);

-- 
To view, visit https://gerrit.wikimedia.org/r/241104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe18abd4e7ee19e9f0ed07440503bbf3b3627fa0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroBanner
Gerrit-Branch: master
Gerrit-Owner: Jhobs 
Gerrit-Reviewer: Jhobs 
Gerrit-Reviewer: Yurik 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits