[MediaWiki-commits] [Gerrit] Introduce finer-grained Media Viewer EventLogging sampling - change (operations/mediawiki-config)
jenkins-bot has submitted this change and it was merged. Change subject: Introduce finer-grained Media Viewer EventLogging sampling .. Introduce finer-grained Media Viewer EventLogging sampling Related code change: I3966bf5dfe9ed607bda8e87f3b1924de37716dcf Change-Id: I5c78d34fd6423cb6f8b599e2e8e2d0f4492a1b54 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619 --- M wmf-config/CommonSettings.php M wmf-config/InitialiseSettings.php 2 files changed, 54 insertions(+), 3 deletions(-) Approvals: Anomie: Looks good to me, approved jenkins-bot: Verified diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php index be683f0..5b88315 100644 --- a/wmf-config/CommonSettings.php +++ b/wmf-config/CommonSettings.php @@ -1803,7 +1803,8 @@ if ( $wmgUseMultimediaViewer ) { require_once( $IP/extensions/MultimediaViewer/MultimediaViewer.php ); $wgNetworkPerformanceSamplingFactor = $wmgNetworkPerformanceSamplingFactor; - $wgMediaViewerSamplingFactor = $wmgMediaViewerSamplingFactor; + $wgMediaViewerDurationLoggingSamplingFactor = $wmgMediaViewerDurationLoggingSamplingFactor; + $wgMediaViewerActionLoggingSamplingFactorMap = $wmgMediaViewerActionLoggingSamplingFactorMap; if ( $wmgMediaViewerBeta ) { $wgMediaViewerIsInBeta = true; diff --git a/wmf-config/InitialiseSettings.php b/wmf-config/InitialiseSettings.php index 7845a38..1047762 100644 --- a/wmf-config/InitialiseSettings.php +++ b/wmf-config/InitialiseSettings.php @@ -10794,6 +10794,8 @@ 'votewiki' = false, ), +// BetaFeatures end --- + // -- Media Viewer configs -- 'wmgUseMultimediaViewer' = array( 'default' = true, @@ -10832,12 +10834,60 @@ 'mediaviewer' = 1000, ), -'wmgMediaViewerSamplingFactor' = array( +'wmgMediaViewerDurationLoggingSamplingFactor' = array( 'default' = 10, 'mediaviewer' = 1000, ), -// BetaFeatures end --- +'wmgMediaViewerActionLoggingSamplingFactorMap' = array( + 'default' = array( 'default' = 1 ), + 'mediaviewer' = array( 'default' = 1 ), + 'commonswiki' = array( + 'default' = 1, + 'image-view' = 100, + 'thumbnail-click' = 100, + 'close' = 100, + 'next-image' = 10, + 'prev-image' = 10, + 'history-navigation' = 10, + ), + 'eswiki' = array( + 'default' = 1, + 'image-view' = 100, + 'thumbnail-click' = 100, + 'close' = 100, + 'next-image' = 10, + 'prev-image' = 10, + 'history-navigation' = 10, + ), + 'frwiki' = array( + 'default' = 1, + 'image-view' = 100, + 'thumbnail-click' = 100, + 'close' = 100, + 'next-image' = 10, + 'prev-image' = 10, + 'history-navigation' = 10, + ), + 'jawiki' = array( + 'default' = 1, + 'image-view' = 100, + 'thumbnail-click' = 100, + 'close' = 100, + 'next-image' = 10, + 'prev-image' = 10, + 'history-navigation' = 10, + ), + 'plwiki' = array( + 'default' = 1, + 'image-view' = 100, + 'thumbnail-click' = 100, + 'close' = 100, + 'next-image' = 10, + 'prev-image' = 10, + 'history-navigation' = 10, + ), +), // -- VisualEditor start -- -- To view, visit https://gerrit.wikimedia.org/r/134343 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c78d34fd6423cb6f8b599e2e8e2d0f4492a1b54 Gerrit-PatchSet: 3 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Gilles gdu...@wikimedia.org Gerrit-Reviewer: Anomie bjor...@wikimedia.org Gerrit-Reviewer: Gergő Tisza gti...@wikimedia.org Gerrit-Reviewer: Gilles gdu...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Introduce finer-grained Media Viewer EventLogging sampling - change (operations/mediawiki-config)
Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/134343 Change subject: Introduce finer-grained Media Viewer EventLogging sampling .. Introduce finer-grained Media Viewer EventLogging sampling Change-Id: I5c78d34fd6423cb6f8b599e2e8e2d0f4492a1b54 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/619 --- M wmf-config/CommonSettings.php M wmf-config/InitialiseSettings.php 2 files changed, 19 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config refs/changes/43/134343/1 diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php index d185799..2f93d7e 100644 --- a/wmf-config/CommonSettings.php +++ b/wmf-config/CommonSettings.php @@ -1811,7 +1811,8 @@ if ( $wmgUseMultimediaViewer ) { require_once( $IP/extensions/MultimediaViewer/MultimediaViewer.php ); $wgNetworkPerformanceSamplingFactor = $wmgNetworkPerformanceSamplingFactor; - $wgMediaViewerSamplingFactor = $wmgMediaViewerSamplingFactor; + $wgMediaViewerDurationLoggingSamplingFactor = $wmgMediaViewerDurationLoggingSamplingFactor; + $wgMediaViewerActionLoggingSamplingFactorMap = $wmgMediaViewerActionLoggingSamplingFactorMap; if ( $wmgMediaViewerBeta ) { $wgMediaViewerIsInBeta = true; diff --git a/wmf-config/InitialiseSettings.php b/wmf-config/InitialiseSettings.php index 3f6c8ad..32decb9 100644 --- a/wmf-config/InitialiseSettings.php +++ b/wmf-config/InitialiseSettings.php @@ -10794,6 +10794,8 @@ 'votewiki' = false, ), +// BetaFeatures end --- + // -- Media Viewer configs -- 'wmgUseMultimediaViewer' = array( 'default' = true, @@ -10832,12 +10834,25 @@ 'mediaviewer' = 1000, ), -'wmgMediaViewerSamplingFactor' = array( +'wmgMediaViewerDurationLoggingSamplingFactor' = array( 'default' = 10, 'mediaviewer' = 1000, ), -// BetaFeatures end --- +'wmgMediaViewerActionLoggingSamplingFactorMap' = array( + 'default' = array( 'default' = 1 ), + 'mediaviewer' = array( 'default' = 1 ), + 'commonswiki' = array( 'default' = 1, 'image-view' = 100, 'thumbnail-click' = 100, 'close' = 100, + 'next-image' = 10, 'prev-image' = 10, 'history-navigation' = 10, ), + 'eswiki' = array( 'default' = 1, 'image-view' = 100, 'thumbnail-click' = 100, 'close' = 100, + 'next-image' = 10, 'prev-image' = 10, 'history-navigation' = 10, ), + 'frwiki' = array( 'default' = 1, 'image-view' = 100, 'thumbnail-click' = 100, 'close' = 100, + 'next-image' = 10, 'prev-image' = 10, 'history-navigation' = 10, ), + 'jawiki' = array( 'default' = 1, 'image-view' = 100, 'thumbnail-click' = 100, 'close' = 100, + 'next-image' = 10, 'prev-image' = 10, 'history-navigation' = 10, ), + 'plwiki' = array( 'default' = 1, 'image-view' = 100, 'thumbnail-click' = 100, 'close' = 100, + 'next-image' = 10, 'prev-image' = 10, 'history-navigation' = 10, ), +), // -- VisualEditor start -- -- To view, visit https://gerrit.wikimedia.org/r/134343 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5c78d34fd6423cb6f8b599e2e8e2d0f4492a1b54 Gerrit-PatchSet: 1 Gerrit-Project: operations/mediawiki-config Gerrit-Branch: master Gerrit-Owner: Gilles gdu...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits