Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/72056
Change subject: Layout fix for Link Surface in RTL
......................................................................
Layout fix for Link Surface in RTL
This is a fix at least until CSSJanus is active inside iframes.
It flips the positions of the window icons (close/back/remove)
and should work for all inspector surfaces.
Bug: 50490
Change-Id: Ic363b43cd1a2b7340a9275126eeab3cf07fd7f6f
---
M modules/ve/ui/styles/ve.ui.Inspector.css
1 file changed, 24 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/56/72056/1
diff --git a/modules/ve/ui/styles/ve.ui.Inspector.css
b/modules/ve/ui/styles/ve.ui.Inspector.css
index 514f869..32f1793 100644
--- a/modules/ve/ui/styles/ve.ui.Inspector.css
+++ b/modules/ve/ui/styles/ve.ui.Inspector.css
@@ -29,14 +29,38 @@
border-left: solid 1px #eee;
}
+/*@noflip*/
+.ve-rtl div .ve-ui-window-icon {
+ padding: 0px;
+ margin: 0px;
+ border: 0px;
+ padding-right: 0.5em;
+ margin-right: 0.25em;
+ border-right: solid 1px #eee;
+}
+
.ve-ui-inspector-closeButton {
float: left;
}
+/*@noflip*/
+.ve-rtl div .ve-ui-inspector-closeButton {
+ float: right;
+ /** This background image is, for some reason, reversed LTR and RTL.
+ I'm adding a fix here temporarily until CSSJanus is active inside frames
+ which will sort this out anyways*/
+ background-image: url("images/icons/move-ltr.svg")
+}
+
.ve-ui-inspector-removeButton {
float: right;
}
+/*@noflip*/
+.ve-rtl div .ve-ui-inspector-removeButton {
+ float: left;
+}
+
.ve-ui-window-body form {
margin: 0.25em 0 0 0;
padding: 0;
--
To view, visit https://gerrit.wikimedia.org/r/72056
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic363b43cd1a2b7340a9275126eeab3cf07fd7f6f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
