[MediaWiki-commits] [Gerrit] Made DB errors go to the exception log again - change (mediawiki/core)
jenkins-bot has submitted this change and it was merged.
Change subject: Made DB errors go to the exception log again
..
Made DB errors go to the exception log again
* Some DB errors are caught while others bubble up to users.
It is useful to log the latter separately and it also provides
more context. The exception logs have a backtrace where as the
regular DB logs do not.
Change-Id: I7ef7693d96e0258119f714e678099e4813ca0c94
---
M includes/db/DatabaseError.php
1 file changed, 0 insertions(+), 8 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/db/DatabaseError.php b/includes/db/DatabaseError.php
index 3bcf638..4d5c3dc 100644
--- a/includes/db/DatabaseError.php
+++ b/includes/db/DatabaseError.php
@@ -348,14 +348,6 @@
}
/**
-* @return bool
-*/
- function isLoggable() {
- // Don't send to the exception log, already in dberror log
- return false;
- }
-
- /**
* @return string
*/
function getPageTitle() {
--
To view, visit https://gerrit.wikimedia.org/r/130117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ef7693d96e0258119f714e678099e4813ca0c94
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz asch...@wikimedia.org
Gerrit-Reviewer: Chad ch...@wikimedia.org
Gerrit-Reviewer: Ori.livneh o...@wikimedia.org
Gerrit-Reviewer: Parent5446 tylerro...@gmail.com
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Made DB errors go to the exception log again - change (mediawiki/core)
Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/130117
Change subject: Made DB errors go to the exception log again
..
Made DB errors go to the exception log again
* Some DB errors are caught while others bubble up to users.
It is useful to log the latter separately and it also provides
more context. The exception logs have a backtrace where as the
regular DB logs do not.
Change-Id: I7ef7693d96e0258119f714e678099e4813ca0c94
---
M includes/db/DatabaseError.php
1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/17/130117/1
diff --git a/includes/db/DatabaseError.php b/includes/db/DatabaseError.php
index 3bcf638..4d5c3dc 100644
--- a/includes/db/DatabaseError.php
+++ b/includes/db/DatabaseError.php
@@ -348,14 +348,6 @@
}
/**
-* @return bool
-*/
- function isLoggable() {
- // Don't send to the exception log, already in dberror log
- return false;
- }
-
- /**
* @return string
*/
function getPageTitle() {
--
To view, visit https://gerrit.wikimedia.org/r/130117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ef7693d96e0258119f714e678099e4813ca0c94
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz asch...@wikimedia.org
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
