[MediaWiki-commits] [Gerrit] Made WebVideoTranscodeJob bail if the work is started already - change (mediawiki...TimedMediaHandler)

2015-07-28 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Made WebVideoTranscodeJob bail if the work is started already
..


Made WebVideoTranscodeJob bail if the work is started already

* Previously it would spam the job logs with errors and keep retrying
  the job, which just makes noise.

Change-Id: I443ef991f73642cc30793a6fde6979efd711d8c1
---
M WebVideoTranscode/WebVideoTranscodeJob.php
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Gilles: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/WebVideoTranscode/WebVideoTranscodeJob.php 
b/WebVideoTranscode/WebVideoTranscodeJob.php
old mode 100644
new mode 100755
index c78583b..5308c46
--- a/WebVideoTranscode/WebVideoTranscodeJob.php
+++ b/WebVideoTranscode/WebVideoTranscodeJob.php
@@ -163,8 +163,7 @@
if( ! is_null( $dbStartTime ) ){
$error = 'Error, running transcode job, for job that 
has already started';
$this-output( $error );
-   $this-setLastError( $error );
-   return false;
+   return true;
}
 
// Update the transcode table letting it know we have started 
work:

-- 
To view, visit https://gerrit.wikimedia.org/r/226617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I443ef991f73642cc30793a6fde6979efd711d8c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz asch...@wikimedia.org
Gerrit-Reviewer: Gilles gdu...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Made WebVideoTranscodeJob bail if the work is started already - change (mediawiki...TimedMediaHandler)

2015-07-23 Thread Aaron Schulz (Code Review) 
Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/226617

Change subject: Made WebVideoTranscodeJob bail if the work is started already
..

Made WebVideoTranscodeJob bail if the work is started already

* Previously it would spam the job logs with errors and keep retrying
  the job, which just makes noise.

Change-Id: I443ef991f73642cc30793a6fde6979efd711d8c1
---
M WebVideoTranscode/WebVideoTranscodeJob.php
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/17/226617/1

diff --git a/WebVideoTranscode/WebVideoTranscodeJob.php 
b/WebVideoTranscode/WebVideoTranscodeJob.php
old mode 100644
new mode 100755
index c78583b..5308c46
--- a/WebVideoTranscode/WebVideoTranscodeJob.php
+++ b/WebVideoTranscode/WebVideoTranscodeJob.php
@@ -163,8 +163,7 @@
if( ! is_null( $dbStartTime ) ){
$error = 'Error, running transcode job, for job that 
has already started';
$this-output( $error );
-   $this-setLastError( $error );
-   return false;
+   return true;
}
 
// Update the transcode table letting it know we have started 
work:

-- 
To view, visit https://gerrit.wikimedia.org/r/226617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I443ef991f73642cc30793a6fde6979efd711d8c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz asch...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits