[MediaWiki-commits] [Gerrit] Make JavaScript code and CSS follow the style guide. - change (mediawiki...RevisionSlider)
jenkins-bot has submitted this change and it was merged.
Change subject: Make JavaScript code and CSS follow the style guide.
..
Make JavaScript code and CSS follow the style guide.
Changes include:
- not passing in HTML attributes when creating tag elements,
- creating HTML elements instead of appending hand-crafted HTML,
- single append() calls instead of multiple consecutie appends,
- not using raw HTML messages when not needed,
- prefixing all CSS classes and IDs with "mw-" to avoid potential
name conflicts.
Change-Id: I164538bbaf44d46a4c66659f56e07ec7225d7fa9
---
M RevisionSlider.hooks.php
M extension.json
M modules/ext.RevisionSlider.DiffPage.js
M modules/ext.RevisionSlider.PointerView.js
M modules/ext.RevisionSlider.RevisionListView.js
M modules/ext.RevisionSlider.SliderView.js
M modules/ext.RevisionSlider.css
M modules/ext.RevisionSlider.init.js
M tests/RevisionSlider.Pointer.test.js
M tests/RevisionSlider.PointerView.test.js
M tests/RevisionSlider.SliderView.test.js
11 files changed, 165 insertions(+), 156 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/RevisionSlider.hooks.php b/RevisionSlider.hooks.php
index ac7a8f6..6b1c231 100755
--- a/RevisionSlider.hooks.php
+++ b/RevisionSlider.hooks.php
@@ -45,13 +45,13 @@
Html::rawElement(
'div',
[
- 'id' => 'revision-slider-container',
+ 'id' => 'mw-revision-slider-container',
'style' => 'min-height: 150px;',
],
Html::element(
'p',
[
- 'id' =>
'revision-slider-placeholder',
+ 'id' =>
'mw-revision-slider-placeholder',
'style' => 'text-align: center',
],
( new Message(
'revisionslider-loading-placeholder' ) )->parse()
diff --git a/extension.json b/extension.json
index 7ed5dc5..e6d19a9 100755
--- a/extension.json
+++ b/extension.json
@@ -118,7 +118,7 @@
"ext.RevisionSlider.arrows.left": {
"position": "top",
"class": "ResourceLoaderImageModule",
- "selector": ".arrow-left.arrow-{name}",
+ "selector": ".mw-arrow-left.mw-arrow-{name}",
"images": {
"enabled":
"resources/ext.RevisionSlider.arrows/arrow-left-enabled.svg",
"hovered":
"resources/ext.RevisionSlider.arrows/arrow-left-hovered.svg",
@@ -128,7 +128,7 @@
"ext.RevisionSlider.arrows.right": {
"position": "top",
"class": "ResourceLoaderImageModule",
- "selector": ".arrow-right.arrow-{name}",
+ "selector": ".mw-arrow-right.mw-arrow-{name}",
"images": {
"enabled":
"resources/ext.RevisionSlider.arrows/arrow-right-enabled.svg",
"hovered":
"resources/ext.RevisionSlider.arrows/arrow-right-hovered.svg",
@@ -138,7 +138,7 @@
"ext.RevisionSlider.pointers.lower": {
"position": "top",
"class": "ResourceLoaderImageModule",
- "selector": ".lower-pointer.{name}-pointer",
+ "selector": ".mw-lower-pointer.mw-{name}-pointer",
"images": {
"oldid":
"resources/ext.RevisionSlider.pointers/pointer-lower-old.svg",
"newid":
"resources/ext.RevisionSlider.pointers/pointer-lower-new.svg"
@@ -147,7 +147,7 @@
"ext.RevisionSlider.pointers.upper": {
"position": "top",
"class": "ResourceLoaderImageModule",
- "selector": ".upper-pointer.{name}-pointer",
+ "selector": ".mw-upper-pointer.mw-{name}-pointer",
"images": {
"oldid":
"resources/ext.RevisionSlider.pointers/pointer-upper-old.svg",
"newid":
"resources/ext.RevisionSlider.pointers/pointer-upper-new.svg"
diff --git a/modules/ext.RevisionSlider.DiffPage.js
b/modules/ext.RevisionSlider.DiffPage.js
index 2872170..6c520d6 100644
--- a/modules/ext.RevisionSlider.DiffPage.js
+++ b/modules/ext.RevisionSlider.DiffPage.js
@@ -4,8 +4,10 @@
$.extend( DiffPage.prototype, {
refresh: function ( revId1,
[MediaWiki-commits] [Gerrit] Make JavaScript code and CSS follow the style guide. - change (mediawiki...RevisionSlider)
WMDE-leszek has uploaded a new change for review.
https://gerrit.wikimedia.org/r/291754
Change subject: Make JavaScript code and CSS follow the style guide.
..
Make JavaScript code and CSS follow the style guide.
Changes include:
- not passing in HTML attributes when creating tag elements,
- creating HTML elements instead of appending hand-crafted HTML,
- single append() calls instead of multiple consecutie appends,
- not using raw HTML messages when not needed,
- prefixing all CSS classes and IDs with "mw-" to avoid potential
name conflicts.
Change-Id: I164538bbaf44d46a4c66659f56e07ec7225d7fa9
---
M RevisionSlider.hooks.php
M extension.json
M modules/ext.RevisionSlider.DiffPage.js
M modules/ext.RevisionSlider.PointerView.js
M modules/ext.RevisionSlider.RevisionListView.js
M modules/ext.RevisionSlider.SliderView.js
M modules/ext.RevisionSlider.css
M modules/ext.RevisionSlider.init.js
M tests/RevisionSlider.Pointer.test.js
M tests/RevisionSlider.PointerView.test.js
M tests/RevisionSlider.SliderView.test.js
11 files changed, 161 insertions(+), 154 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider
refs/changes/54/291754/1
diff --git a/RevisionSlider.hooks.php b/RevisionSlider.hooks.php
index ac7a8f6..6b1c231 100755
--- a/RevisionSlider.hooks.php
+++ b/RevisionSlider.hooks.php
@@ -45,13 +45,13 @@
Html::rawElement(
'div',
[
- 'id' => 'revision-slider-container',
+ 'id' => 'mw-revision-slider-container',
'style' => 'min-height: 150px;',
],
Html::element(
'p',
[
- 'id' =>
'revision-slider-placeholder',
+ 'id' =>
'mw-revision-slider-placeholder',
'style' => 'text-align: center',
],
( new Message(
'revisionslider-loading-placeholder' ) )->parse()
diff --git a/extension.json b/extension.json
index 7ed5dc5..e6d19a9 100755
--- a/extension.json
+++ b/extension.json
@@ -118,7 +118,7 @@
"ext.RevisionSlider.arrows.left": {
"position": "top",
"class": "ResourceLoaderImageModule",
- "selector": ".arrow-left.arrow-{name}",
+ "selector": ".mw-arrow-left.mw-arrow-{name}",
"images": {
"enabled":
"resources/ext.RevisionSlider.arrows/arrow-left-enabled.svg",
"hovered":
"resources/ext.RevisionSlider.arrows/arrow-left-hovered.svg",
@@ -128,7 +128,7 @@
"ext.RevisionSlider.arrows.right": {
"position": "top",
"class": "ResourceLoaderImageModule",
- "selector": ".arrow-right.arrow-{name}",
+ "selector": ".mw-arrow-right.mw-arrow-{name}",
"images": {
"enabled":
"resources/ext.RevisionSlider.arrows/arrow-right-enabled.svg",
"hovered":
"resources/ext.RevisionSlider.arrows/arrow-right-hovered.svg",
@@ -138,7 +138,7 @@
"ext.RevisionSlider.pointers.lower": {
"position": "top",
"class": "ResourceLoaderImageModule",
- "selector": ".lower-pointer.{name}-pointer",
+ "selector": ".mw-lower-pointer.mw-{name}-pointer",
"images": {
"oldid":
"resources/ext.RevisionSlider.pointers/pointer-lower-old.svg",
"newid":
"resources/ext.RevisionSlider.pointers/pointer-lower-new.svg"
@@ -147,7 +147,7 @@
"ext.RevisionSlider.pointers.upper": {
"position": "top",
"class": "ResourceLoaderImageModule",
- "selector": ".upper-pointer.{name}-pointer",
+ "selector": ".mw-upper-pointer.mw-{name}-pointer",
"images": {
"oldid":
"resources/ext.RevisionSlider.pointers/pointer-upper-old.svg",
"newid":
"resources/ext.RevisionSlider.pointers/pointer-upper-new.svg"
diff --git a/modules/ext.RevisionSlider.DiffPage.js
b/modules/ext.RevisionSlider.DiffPage.js
index 63b6dab..e6e42d4 100644
--- a/modules/ext.RevisionSlider.DiffPage.js
+++ b/modules/ext.RevisionSlider.DiffPage.js
@@ -4,8 +4,8 @@
$.extend(
