[MediaWiki-commits] [Gerrit] Make SpecialPages Titlecase in misc::maintenance::updatequer... - change (operations/puppet)

2013-08-16 Thread ArielGlenn (Code Review) 
ArielGlenn has submitted this change and it was merged.

Change subject: Make SpecialPages Titlecase in 
misc::maintenance::updatequerypages
..


Make SpecialPages Titlecase in misc::maintenance::updatequerypages

My CamelCase consistency scruple was not a good thing.
The updates were still be done only for wikis in
https://noc.wikimedia.org/conf/highlight.php?file=small.dblist
where they are not disabled; the override did not work
for the others and the script defaulted to updating
only Special:Statistics, it seems, ignoring all the rest
and considering the job done successfully (verified by Reedy).

Bug: 15434
Change-Id: I725d07397cfa6e61e0644a9a40635d608f6be98d
---
M manifests/misc/maintenance.pp
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Reedy: Looks good to me, but someone else must approve
  ArielGlenn: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/manifests/misc/maintenance.pp b/manifests/misc/maintenance.pp
index 9bd8728..f506ae6 100644
--- a/manifests/misc/maintenance.pp
+++ b/manifests/misc/maintenance.pp
@@ -417,7 +417,7 @@
 }
 
 cron { "cron-updatequerypages-ancientpages-${name}":
-command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=AncientPages > 
/home/mwdeploy/updateSpecialPages/${name}-AncientPages.log 2>&1",
+command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=Ancientpages > 
/home/mwdeploy/updateSpecialPages/${name}-AncientPages.log 2>&1",
 month => [1, 7],
 ensure => $enabled ?{
   true => present,
@@ -427,7 +427,7 @@
 }
 
 cron { "cron-updatequerypages-deadendpages-${name}":
-command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=DeadendPages > 
/home/mwdeploy/updateSpecialPages/${name}-DeadendPages.log 2>&1",
+command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=Deadendpages > 
/home/mwdeploy/updateSpecialPages/${name}-DeadendPages.log 2>&1",
 month => [2, 8],
 ensure => $enabled ?{
   true => present,
@@ -437,7 +437,7 @@
 }
 
 cron { "cron-updatequerypages-mostlinked-${name}":
-command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=MostLinked > 
/home/mwdeploy/updateSpecialPages/${name}-MostLinked.log 2>&1",
+command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=Mostlinked > 
/home/mwdeploy/updateSpecialPages/${name}-MostLinked.log 2>&1",
 month => [3, 9],
 ensure => $enabled ?{
   true => present,
@@ -447,7 +447,7 @@
 }
 
 cron { "cron-updatequerypages-mostrevisions-${name}":
-command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=MostRevisions > 
/home/mwdeploy/updateSpecialPages/${name}-MostRevisions.log 2>&1",
+command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=Mostrevisions > 
/home/mwdeploy/updateSpecialPages/${name}-MostRevisions.log 2>&1",
 month => [4, 10],
 ensure => $enabled ?{
   true => present,
@@ -457,7 +457,7 @@
 }
 
 cron { "cron-updatequerypages-wantedpages-${name}":
-command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=WantedPages > 
/home/mwdeploy/updateSpecialPages/${name}-WantedPages.log 2>&1",
+command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=Wantedpages > 
/home/mwdeploy/updateSpecialPages/${name}-WantedPages.log 2>&1",
 month => [5, 11],
 ensure => $enabled ?{
   true => present,
@@ -467,7 +467,7 @@
 }
 
 cron { "cron-updatequerypages-fewestrevisions-${name}":
-command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=FewestRevisions > 
/home/mwdeploy/updateSpecialPages/${name}-FewestRevisions.log 2>&1",
+command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=Fewestrevisions > 
/home/mwdeploy/updateSpecialPages/${name}-FewestRevisions.log 2>&1",

[MediaWiki-commits] [Gerrit] Make SpecialPages Titlecase in misc::maintenance::updatequer... - change (operations/puppet)

2013-08-15 Thread Nemo bis (Code Review) 
Nemo bis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/79279


Change subject: Make SpecialPages Titlecase in 
misc::maintenance::updatequerypages
..

Make SpecialPages Titlecase in misc::maintenance::updatequerypages

My CamelCase consistency scruple was not a good thing.
The updates were still be done only for wikis in
https://noc.wikimedia.org/conf/highlight.php?file=small.dblist
where they are not disabled; the override did not work
for the others and the script defaulted to updating
only Special:Statistics, it seems, ignoring all the rest
and considering the job done successfully (verified by Reedy).

Bug: 15434
Change-Id: I725d07397cfa6e61e0644a9a40635d608f6be98d
---
M manifests/misc/maintenance.pp
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/79/79279/1

diff --git a/manifests/misc/maintenance.pp b/manifests/misc/maintenance.pp
index 9bd8728..f506ae6 100644
--- a/manifests/misc/maintenance.pp
+++ b/manifests/misc/maintenance.pp
@@ -417,7 +417,7 @@
 }
 
 cron { "cron-updatequerypages-ancientpages-${name}":
-command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=AncientPages > 
/home/mwdeploy/updateSpecialPages/${name}-AncientPages.log 2>&1",
+command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=Ancientpages > 
/home/mwdeploy/updateSpecialPages/${name}-AncientPages.log 2>&1",
 month => [1, 7],
 ensure => $enabled ?{
   true => present,
@@ -427,7 +427,7 @@
 }
 
 cron { "cron-updatequerypages-deadendpages-${name}":
-command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=DeadendPages > 
/home/mwdeploy/updateSpecialPages/${name}-DeadendPages.log 2>&1",
+command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=Deadendpages > 
/home/mwdeploy/updateSpecialPages/${name}-DeadendPages.log 2>&1",
 month => [2, 8],
 ensure => $enabled ?{
   true => present,
@@ -437,7 +437,7 @@
 }
 
 cron { "cron-updatequerypages-mostlinked-${name}":
-command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=MostLinked > 
/home/mwdeploy/updateSpecialPages/${name}-MostLinked.log 2>&1",
+command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=Mostlinked > 
/home/mwdeploy/updateSpecialPages/${name}-MostLinked.log 2>&1",
 month => [3, 9],
 ensure => $enabled ?{
   true => present,
@@ -447,7 +447,7 @@
 }
 
 cron { "cron-updatequerypages-mostrevisions-${name}":
-command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=MostRevisions > 
/home/mwdeploy/updateSpecialPages/${name}-MostRevisions.log 2>&1",
+command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=Mostrevisions > 
/home/mwdeploy/updateSpecialPages/${name}-MostRevisions.log 2>&1",
 month => [4, 10],
 ensure => $enabled ?{
   true => present,
@@ -457,7 +457,7 @@
 }
 
 cron { "cron-updatequerypages-wantedpages-${name}":
-command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=WantedPages > 
/home/mwdeploy/updateSpecialPages/${name}-WantedPages.log 2>&1",
+command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=Wantedpages > 
/home/mwdeploy/updateSpecialPages/${name}-WantedPages.log 2>&1",
 month => [5, 11],
 ensure => $enabled ?{
   true => present,
@@ -467,7 +467,7 @@
 }
 
 cron { "cron-updatequerypages-fewestrevisions-${name}":
-command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=FewestRevisions > 
/home/mwdeploy/updateSpecialPages/${name}-FewestRevisions.log 2>&1",
+command => "/usr/local/bin/mwscriptwikiset 
updateSpecialPages.php ${cluster}.dblist --override --only=Fewestrevisions > 
/home/mwdeploy/updateSpecialPages/${name}-FewestRevisions.log 2>&1",