[MediaWiki-commits] [Gerrit] Make it easier to select example - change (wikidata...rdf)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Make it easier to select example
..


Make it easier to select example

Changed links for pasting and editing an example

Change-Id: I53ad39879601de316e79401d6cbba6e45ca0678f
---
M gui/wikibase/queryService/ui/QueryExampleDialog.js
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Smalyshev: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/gui/wikibase/queryService/ui/QueryExampleDialog.js 
b/gui/wikibase/queryService/ui/QueryExampleDialog.js
index 9c9b312..8328cb1 100644
--- a/gui/wikibase/queryService/ui/QueryExampleDialog.js
+++ b/gui/wikibase/queryService/ui/QueryExampleDialog.js
@@ -204,12 +204,12 @@
SELF.prototype._addExample = function( title, query, href, tags ) {
var self = this;
 
-   var title = $( '' ).text(title).attr( 'href', href ).attr( 
'target', '_blank' ),
-   tags = $( '' ).text( tags.join( '|' ) ).hide(),
-   select = $( ''
-   +'' ).click( function(){
-   self._callback( query );
+   var link = $( '' ).text(title).attr( 'href', '#' ).click( function(){
+   self._callback( query );
} ),
+   tags = $( '' ).text( tags.join( '|' ) ).hide(),
+   edit = $( '' ).attr( 'href', 
href ).attr( 'target', '_blank' )
+   .append( '' ),
preview = $( '' ).popover({
placement: 'bottom',
trigger: 'hover',
@@ -220,9 +220,9 @@
});
 
var example = $( '' );
-   example.append( $( '' ).append( title ) );
+   example.append( $( '' ).append( link ) );
example.append( $( '' ).append( preview ) );
-   example.append( $( '' ).append( select ) );
+   example.append( $( '' ).append( edit ) );
example.append( tags );
 
this._$element.find( '.searchable' ).append( example );

-- 
To view, visit https://gerrit.wikimedia.org/r/261986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I53ad39879601de316e79401d6cbba6e45ca0678f
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 
Gerrit-Reviewer: Lydia Pintscher 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Make it easier to select example - change (wikidata...rdf)

[Jonas Kress (WMDE) (Code Review)]

Jonas Kress (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/261986

Change subject: Make it easier to select example
..

Make it easier to select example

Changed links for pasting and editing an example

Change-Id: I53ad39879601de316e79401d6cbba6e45ca0678f
---
M gui/wikibase/queryService/ui/QueryExampleDialog.js
1 file changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/rdf 
refs/changes/86/261986/1

diff --git a/gui/wikibase/queryService/ui/QueryExampleDialog.js 
b/gui/wikibase/queryService/ui/QueryExampleDialog.js
index 9c9b312..8328cb1 100644
--- a/gui/wikibase/queryService/ui/QueryExampleDialog.js
+++ b/gui/wikibase/queryService/ui/QueryExampleDialog.js
@@ -204,12 +204,12 @@
SELF.prototype._addExample = function( title, query, href, tags ) {
var self = this;
 
-   var title = $( '' ).text(title).attr( 'href', href ).attr( 
'target', '_blank' ),
-   tags = $( '' ).text( tags.join( '|' ) ).hide(),
-   select = $( ''
-   +'' ).click( function(){
-   self._callback( query );
+   var link = $( '' ).text(title).attr( 'href', '#' ).click( function(){
+   self._callback( query );
} ),
+   tags = $( '' ).text( tags.join( '|' ) ).hide(),
+   edit = $( '' ).attr( 'href', 
href ).attr( 'target', '_blank' )
+   .append( '' ),
preview = $( '' ).popover({
placement: 'bottom',
trigger: 'hover',
@@ -220,9 +220,9 @@
});
 
var example = $( '' );
-   example.append( $( '' ).append( title ) );
+   example.append( $( '' ).append( link ) );
example.append( $( '' ).append( preview ) );
-   example.append( $( '' ).append( select ) );
+   example.append( $( '' ).append( edit ) );
example.append( tags );
 
this._$element.find( '.searchable' ).append( example );

-- 
To view, visit https://gerrit.wikimedia.org/r/261986
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I53ad39879601de316e79401d6cbba6e45ca0678f
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits