[MediaWiki-commits] [Gerrit] MediaWiki Theme: Don't use 'box-shadow' to produce thin grey... - change (oojs/ui)

2015-01-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: MediaWiki Theme: Don't use 'box-shadow' to produce thin grey 
lines in dialogs
..


MediaWiki Theme: Don't use 'box-shadow' to produce thin grey lines in dialogs

At least the Blink rendering engine is wonky and the shadows sometimes
become invisible. Using 'outline' instead, as it doesn't seem to have
these problems and is functionally identical otherwise.

Bug: T85226
Change-Id: I0451ad0736a1e84404cd566157c14e5f2a3b9a4b
---
M src/themes/mediawiki/windows.less
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/themes/mediawiki/windows.less 
b/src/themes/mediawiki/windows.less
index 8e2742c..9bf8ee2 100644
--- a/src/themes/mediawiki/windows.less
+++ b/src/themes/mediawiki/windows.less
@@ -11,7 +11,7 @@
 
 .theme-oo-ui-dialog () {
-content  .oo-ui-window-body {
-   box-shadow: 0 0 1px 0 #aaa;
+   outline: 1px solid #aaa;
}
 }
 
@@ -130,7 +130,7 @@
 
.oo-ui-window-body {
top: 3.4em;
-   box-shadow: 0 0 0 1px rgba(0,0,0,0.2);
+   outline: 1px solid rgba(0,0,0,0.2);
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/184198
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0451ad0736a1e84404cd566157c14e5f2a3b9a4b
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński matma@gmail.com
Gerrit-Reviewer: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] MediaWiki Theme: Don't use 'box-shadow' to produce thin grey... - change (oojs/ui)

2015-01-10 Thread Code Review 
Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/184198

Change subject: MediaWiki Theme: Don't use 'box-shadow' to produce thin grey 
lines in dialogs
..

MediaWiki Theme: Don't use 'box-shadow' to produce thin grey lines in dialogs

At least the Blink rendering engine is wonky and the shadows sometimes
become invisible. Using 'outline' instead, as it doesn't seem to have
these problems and is functionally identical otherwise.

Bug: T85226
Change-Id: I0451ad0736a1e84404cd566157c14e5f2a3b9a4b
---
M src/themes/mediawiki/windows.less
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/98/184198/1

diff --git a/src/themes/mediawiki/windows.less 
b/src/themes/mediawiki/windows.less
index 8e2742c..9bf8ee2 100644
--- a/src/themes/mediawiki/windows.less
+++ b/src/themes/mediawiki/windows.less
@@ -11,7 +11,7 @@
 
 .theme-oo-ui-dialog () {
-content  .oo-ui-window-body {
-   box-shadow: 0 0 1px 0 #aaa;
+   outline: 1px solid #aaa;
}
 }
 
@@ -130,7 +130,7 @@
 
.oo-ui-window-body {
top: 3.4em;
-   box-shadow: 0 0 0 1px rgba(0,0,0,0.2);
+   outline: 1px solid rgba(0,0,0,0.2);
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/184198
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0451ad0736a1e84404cd566157c14e5f2a3b9a4b
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński matma@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits