[MediaWiki-commits] [Gerrit] Message on diff page for post should use board title, not UUID - change (mediawiki...Flow)

2014-08-25 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Message on diff page for post should use board title, not UUID
..


Message on diff page for post should use board title, not UUID

Change-Id: If54b7c253c461780ea1d1fbbb351b270a7733feb
---
M includes/Formatter/RevisionViewFormatter.php
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Matthias Mullie: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Formatter/RevisionViewFormatter.php 
b/includes/Formatter/RevisionViewFormatter.php
index 1f81edd..551a662 100644
--- a/includes/Formatter/RevisionViewFormatter.php
+++ b/includes/Formatter/RevisionViewFormatter.php
@@ -79,12 +79,11 @@
),
'title' = wfMessage( 'hist' )
);
+
+   $boardTitle = $row-workflow-getOwnerTitle();
$links['board'] = array(
-   'url' = $this-urlGenerator-generateUrl(
-   $row-workflow,
-   'view'
-   ),
-   'title' = $row-workflow-getArticleTitle()
+   'url' = $this-urlGenerator-boardLink( $boardTitle 
)-getFullURL(),
+   'title' = $boardTitle
);
if ( $row-revision instanceof PostRevision || $row-revision 
instanceof PostSummary ) {
$links['root'] = array(

-- 
To view, visit https://gerrit.wikimedia.org/r/155849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If54b7c253c461780ea1d1fbbb351b270a7733feb
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Bsitu bs...@wikimedia.org
Gerrit-Reviewer: Matthias Mullie mmul...@wikimedia.org
Gerrit-Reviewer: SG shah...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Message on diff page for post should use board title, not UUID - change (mediawiki...Flow)

2014-08-22 Thread Bsitu (Code Review) 
Bsitu has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/155849

Change subject: Message on diff page for post should use board title, not UUID
..

Message on diff page for post should use board title, not UUID

Change-Id: If54b7c253c461780ea1d1fbbb351b270a7733feb
---
M includes/Formatter/RevisionViewFormatter.php
1 file changed, 4 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/49/155849/1

diff --git a/includes/Formatter/RevisionViewFormatter.php 
b/includes/Formatter/RevisionViewFormatter.php
index 1f81edd..c758745 100644
--- a/includes/Formatter/RevisionViewFormatter.php
+++ b/includes/Formatter/RevisionViewFormatter.php
@@ -79,12 +79,11 @@
),
'title' = wfMessage( 'hist' )
);
+
+   $boardTitle = $row-workflow-getOwnerTitle();
$links['board'] = array(
-   'url' = $this-urlGenerator-generateUrl(
-   $row-workflow,
-   'view'
-   ),
-   'title' = $row-workflow-getArticleTitle()
+   'url' = $this-urlGenerator-BoardLink( $boardTitle 
)-getFullURL(),
+   'title' = $boardTitle
);
if ( $row-revision instanceof PostRevision || $row-revision 
instanceof PostSummary ) {
$links['root'] = array(

-- 
To view, visit https://gerrit.wikimedia.org/r/155849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If54b7c253c461780ea1d1fbbb351b270a7733feb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Bsitu bs...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits