[MediaWiki-commits] [Gerrit] Migrate article images from un-migrated save page entries - change (apps...wikipedia)
jenkins-bot has submitted this change and it was merged. Change subject: Migrate article images from un-migrated save page entries .. Migrate article images from un-migrated save page entries At launch, we start a process which recursively grabs an unmigrated entry from the saved page list and - Reads the article data from the data store - Iterates each image - Moves legacy image data into the disk storage under the new image cache - Marks the entry as migrated - Rinse and repeat... - When done, iterate through migrated entries and save the updated list to disk Tests were run migrating 200+ articles while using the app to ensure the background process isn't noticeable to users. Bug: T101527 Change-Id: I2de490556a7902d7e71e3d179bd8f91cd8e17bf7 --- M MediaWikiKit/MediaWikiKit/MWKArticle.h M MediaWikiKit/MediaWikiKit/MWKArticle.m M MediaWikiKit/MediaWikiKit/MWKDataStore.h M MediaWikiKit/MediaWikiKit/MWKDataStore.m M MediaWikiKit/MediaWikiKit/MWKImage.h M MediaWikiKit/MediaWikiKit/MWKImage.m M MediaWikiKit/MediaWikiKit/MWKImageInfo.h M MediaWikiKit/MediaWikiKit/MWKImageList.h M MediaWikiKit/MediaWikiKit/MWKImageList.m M MediaWikiKit/MediaWikiKit/MWKSavedPageEntry.h M MediaWikiKit/MediaWikiKit/MWKSavedPageEntry.m M MediaWikiKit/MediaWikiKit/MWKSavedPageList.h M MediaWikiKit/MediaWikiKit/MWKSavedPageList.m M MediaWikiKit/MediaWikiKit/MWKSiteDataObject.m M Wikipedia.xcodeproj/project.pbxproj M Wikipedia/AppDelegate.m M Wikipedia/Categories/MWKArticle+Convenience.h A Wikipedia/Categories/SDWebImageManager+WMFCacheRemoval.h A Wikipedia/Categories/SDWebImageManager+WMFCacheRemoval.m M Wikipedia/Housekeeping/DataHousekeeping.m A Wikipedia/Housekeeping/WMFBackgroundTaskManager.swift A Wikipedia/Images/SDImageCache+WMFPersistentCache.h A Wikipedia/Images/SDImageCache+WMFPersistentCache.m M Wikipedia/Images/WMFImageController+Debug.swift M Wikipedia/Images/WMFImageController.swift A Wikipedia/Legacy Data Migration/WMFLegacyImageDataMigration.swift M Wikipedia/UI-V5/WMFArticleViewController.m M Wikipedia/UI-V5/iPhone_Root.storyboard M Wikipedia/View Controllers/Image Gallery/WMFImageGalleryViewController.m M Wikipedia/Wikipedia-Bridging-Header.h M Wikipedia/mw-utils/WMFLogging.h A WikipediaUnitTests/Fixtures/ArticleWithoutImages.dataexport.json A WikipediaUnitTests/Fixtures/Barack_Obama/Article.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/100px-Seal_of_the_President_of_the_United_States.svg.png/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/100px-Seal_of_the_President_of_the_United_States.svg.png/Image.png A WikipediaUnitTests/Fixtures/Barack_Obama/Images/110px-2004_Illinois_Senate_results.svg.png/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/110px-2004_Illinois_Senate_results.svg.png/Image.png A WikipediaUnitTests/Fixtures/Barack_Obama/Images/115px-President_Barack_Obama.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/115px-President_Barack_Obama.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-BarackObamaportrait.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-BarackObamaportrait.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-Barack_Obama_at_Cairo_University_cropped.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-Barack_Obama_at_Cairo_University_cropped.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-Barack_Obama_playing_basketball_with_members_of_Congress_and_Cabinet_secretaries_2.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-Barack_Obama_playing_basketball_with_members_of_Congress_and_Cabinet_secretaries_2.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-Official_portrait_of_Barack_Obama.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-Official_portrait_of_Barack_Obama.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px--President_Obama_on_Death_of_Osama_bin_Laden.ogv.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px--President_Obama_on_Death_of_Osama_bin_Laden.ogv.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-2004_Illinois_Senate_results.svg.png/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-2004_Illinois_Senate_results.svg.png/Image.png A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-Ann_Dunham_with_father_and_children.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-Ann_Dunham_with_father_and_children.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-Barack_Obama_addresses_joint_session_of_Congress_2009-02-24.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-Barack_Obama_addresses_joint_session_of_Congress_2009-02-24.jpg/Image.plist A
[MediaWiki-commits] [Gerrit] Migrate article images from un-migrated save page entries - change (apps...wikipedia)
Bgerstle has uploaded a new change for review. https://gerrit.wikimedia.org/r/224115 Change subject: Migrate article images from un-migrated save page entries .. Migrate article images from un-migrated save page entries At launch, we start a process which recursively grabs an unmigrated entry from the saved page list and - Reads the article data from the data store - Iterates each image - Moves legacy image data into the disk storage under the new image cache - Marks the entry as migrated - Rinse and repeat... Bug: T101527 Change-Id: I2de490556a7902d7e71e3d179bd8f91cd8e17bf7 --- M MediaWikiKit/MediaWikiKit/MWKArticle.h M MediaWikiKit/MediaWikiKit/MWKArticle.m M MediaWikiKit/MediaWikiKit/MWKDataStore.h M MediaWikiKit/MediaWikiKit/MWKDataStore.m M MediaWikiKit/MediaWikiKit/MWKImage.h M MediaWikiKit/MediaWikiKit/MWKImage.m M MediaWikiKit/MediaWikiKit/MWKImageInfo.h M MediaWikiKit/MediaWikiKit/MWKImageList.h M MediaWikiKit/MediaWikiKit/MWKImageList.m M MediaWikiKit/MediaWikiKit/MWKSavedPageEntry.h M MediaWikiKit/MediaWikiKit/MWKSavedPageEntry.m M MediaWikiKit/MediaWikiKit/MWKSavedPageList.h M MediaWikiKit/MediaWikiKit/MWKSavedPageList.m M Wikipedia.xcodeproj/project.pbxproj M Wikipedia/AppDelegate.m M Wikipedia/Categories/MWKArticle+Convenience.h A Wikipedia/Categories/SDWebImageManager+WMFCacheRemovalWithDebugging.h A Wikipedia/Categories/SDWebImageManager+WMFCacheRemovalWithDebugging.m M Wikipedia/Housekeeping/DataHousekeeping.m A Wikipedia/Housekeeping/WMFBackgroundTaskManager.swift A Wikipedia/Images/SDImageCache+WMFPersistentCache.h A Wikipedia/Images/SDImageCache+WMFPersistentCache.m M Wikipedia/Images/WMFImageController+Debug.swift M Wikipedia/Images/WMFImageController.swift A Wikipedia/Legacy Data Migration/WMFLegacyImageDataMigration.swift M Wikipedia/UI-V5/iPhone_Root.storyboard M Wikipedia/View Controllers/Image Gallery/WMFImageGalleryViewController.m M Wikipedia/Wikipedia-Bridging-Header.h M Wikipedia/mw-utils/WMFLogging.h A WikipediaUnitTests/Fixtures/ArticleWithoutImages.dataexport.json A WikipediaUnitTests/Fixtures/Barack_Obama/Article.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/100px-Seal_of_the_President_of_the_United_States.svg.png/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/100px-Seal_of_the_President_of_the_United_States.svg.png/Image.png A WikipediaUnitTests/Fixtures/Barack_Obama/Images/110px-2004_Illinois_Senate_results.svg.png/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/110px-2004_Illinois_Senate_results.svg.png/Image.png A WikipediaUnitTests/Fixtures/Barack_Obama/Images/115px-President_Barack_Obama.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/115px-President_Barack_Obama.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-BarackObamaportrait.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-BarackObamaportrait.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-Barack_Obama_at_Cairo_University_cropped.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-Barack_Obama_at_Cairo_University_cropped.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-Barack_Obama_playing_basketball_with_members_of_Congress_and_Cabinet_secretaries_2.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-Barack_Obama_playing_basketball_with_members_of_Congress_and_Cabinet_secretaries_2.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-Official_portrait_of_Barack_Obama.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/170px-Official_portrait_of_Barack_Obama.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px--President_Obama_on_Death_of_Osama_bin_Laden.ogv.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px--President_Obama_on_Death_of_Osama_bin_Laden.ogv.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-2004_Illinois_Senate_results.svg.png/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-2004_Illinois_Senate_results.svg.png/Image.png A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-Ann_Dunham_with_father_and_children.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-Ann_Dunham_with_father_and_children.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-Barack_Obama_addresses_joint_session_of_Congress_2009-02-24.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-Barack_Obama_addresses_joint_session_of_Congress_2009-02-24.jpg/Image.plist A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-Barack_Obama_hangout.jpg/Image.jpg A WikipediaUnitTests/Fixtures/Barack_Obama/Images/220px-Barack_Obama_hangout.jpg/Image.plist A