[MediaWiki-commits] [Gerrit] Minor: Use bunyan.warn for warning/* not just warn/* - change (mediawiki...parsoid)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Minor: Use bunyan.warn for warning/* not just warn/*
..


Minor: Use bunyan.warn for warning/* not just warn/*

Change-Id: I45912fe4f4be5ea55cf7a1d2e536513cfbe47161
---
M lib/Logger.bunyan.js
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Marcoil: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/Logger.bunyan.js b/lib/Logger.bunyan.js
index c224fe6..e5e01e1 100644
--- a/lib/Logger.bunyan.js
+++ b/lib/Logger.bunyan.js
@@ -45,7 +45,7 @@
logger = this._logger.fatal;
} else if (logType.match(/^error($|\/)/)) {
logger = this._logger.error;
-   } else if (logType.match(/^warn($|\/)/)) {
+   } else if (logType.match(/^warn(ing)?($|\/)/)) {
logger = this._logger.warn;
} else if (logType.match(/^info($|\/)/)) {
logger = this._logger.info;
@@ -75,10 +75,6 @@
cb();
 };
 
-BunyanLogger.prototype.getLogger = function() {
-   return this._log.bind(this);
-};
-
 BunyanLogger.prototype._trace = function(logData, cb) {
var logger = this._getBunyanLogger(logData),
log = this._createBunyanLog(logData),
@@ -99,6 +95,10 @@
cb();
 };
 
+BunyanLogger.prototype.getLogger = function() {
+   return this._log.bind(this);
+};
+
 BunyanLogger.prototype.getTracer = function() {
return this._trace.bind(this);
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/166145
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I45912fe4f4be5ea55cf7a1d2e536513cfbe47161
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 
Gerrit-Reviewer: Arlolra 
Gerrit-Reviewer: Cscott 
Gerrit-Reviewer: Marcoil 
Gerrit-Reviewer: Subramanya Sastry 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Minor: Use bunyan.warn for warning/* not just warn/* - change (mediawiki...parsoid)

[Subramanya Sastry (Code Review)]

Subramanya Sastry has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/166145

Change subject: Minor: Use bunyan.warn for warning/* not just warn/*
..

Minor: Use bunyan.warn for warning/* not just warn/*

Change-Id: I45912fe4f4be5ea55cf7a1d2e536513cfbe47161
---
M lib/Logger.bunyan.js
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/45/166145/1

diff --git a/lib/Logger.bunyan.js b/lib/Logger.bunyan.js
index c224fe6..e5e01e1 100644
--- a/lib/Logger.bunyan.js
+++ b/lib/Logger.bunyan.js
@@ -45,7 +45,7 @@
logger = this._logger.fatal;
} else if (logType.match(/^error($|\/)/)) {
logger = this._logger.error;
-   } else if (logType.match(/^warn($|\/)/)) {
+   } else if (logType.match(/^warn(ing)?($|\/)/)) {
logger = this._logger.warn;
} else if (logType.match(/^info($|\/)/)) {
logger = this._logger.info;
@@ -75,10 +75,6 @@
cb();
 };
 
-BunyanLogger.prototype.getLogger = function() {
-   return this._log.bind(this);
-};
-
 BunyanLogger.prototype._trace = function(logData, cb) {
var logger = this._getBunyanLogger(logData),
log = this._createBunyanLog(logData),
@@ -99,6 +95,10 @@
cb();
 };
 
+BunyanLogger.prototype.getLogger = function() {
+   return this._log.bind(this);
+};
+
 BunyanLogger.prototype.getTracer = function() {
return this._trace.bind(this);
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/166145
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45912fe4f4be5ea55cf7a1d2e536513cfbe47161
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits